Skip to content

Fix unsubscribe failures when DataNodes are offline - #19222

Open
Caideyipi wants to merge 1 commit into
masterfrom
fix/subscription-drop-offline-datanodes
Open

Caideyipi wants to merge 1 commit into
masterfrom
fix/subscription-drop-offline-datanodes

Fix unsubscribe failures when DataNodes are offline

33b0eea
Select commit
Loading
Failed to load commit list.
SonarQubeCloud / SonarCloud Code Analysis failed Nov 11, 2026 in 3m 36s

Quality Gate failed

Failed conditions
B Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Annotations

Check failure on line 313 in iotdb-core/datanode/src/main/java/org/apache/iotdb/db/storageengine/dataregion/snapshot/SnapshotLoader.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor this method to reduce its Cognitive Complexity from 17 to the 15 allowed.

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AaHJlS6mom8Y9z6JBCBY&open=AaHJlS6mom8Y9z6JBCBY&pullRequest=19222

Check warning on line 162 in iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/statement/crud/InsertMultiTabletsStatement.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace this usage of 'Stream.collect(Collectors.toList())' with 'Stream.toList()' and ensure that the list is unmodified.

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AaHJlT04om8Y9z6JBCBl&open=AaHJlT04om8Y9z6JBCBl&pullRequest=19222

Check warning on line 71 in iotdb-core/node-commons/src/main/java/org/apache/iotdb/commons/client/internal/subscription/InternalSubscriptionSessionWrapper.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Abbreviation in name 'enableRPCCompaction' must contain no more than '2' consecutive capital letters.

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AaHJlSjxom8Y9z6JBCBT&open=AaHJlSjxom8Y9z6JBCBT&pullRequest=19222

Check warning on line 250 in iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/analyze/load/LoadTsFileTableSchemaCache.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace this instanceof check and cast with 'instanceof IoTDBRuntimeException iotdbruntimeexception'

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AaHJlUWnom8Y9z6JBCBs&open=AaHJlUWnom8Y9z6JBCBs&pullRequest=19222

Check warning on line 636 in iotdb-core/datanode/src/main/java/org/apache/iotdb/db/subscription/receiver/SubscriptionReceiverV1.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Line is longer than 100 characters (found 153).

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AaHJlVh-om8Y9z6JBCB3&open=AaHJlVh-om8Y9z6JBCB3&pullRequest=19222

Check warning on line 155 in iotdb-client/cli/src/main/java/org/apache/iotdb/tool/schema/ImportSchemaTree.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Line is longer than 100 characters (found 157).

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AaHJlXWOom8Y9z6JBCCT&open=AaHJlXWOom8Y9z6JBCCT&pullRequest=19222

Check warning on line 196 in iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/statement/crud/InsertRowsStatement.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace this usage of 'Stream.collect(Collectors.toList())' with 'Stream.toList()' and ensure that the list is unmodified.

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AaHJlT3wom8Y9z6JBCBm&open=AaHJlT3wom8Y9z6JBCBm&pullRequest=19222

Check warning on line 337 in iotdb-core/datanode/src/main/java/org/apache/iotdb/db/storageengine/dataregion/tsfile/TsFileResource.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Expected @throws tag for 'FileNotFoundException'.

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AaHJlSxRom8Y9z6JBCBW&open=AaHJlSxRom8Y9z6JBCBW&pullRequest=19222

Check warning on line 39 in iotdb-core/node-commons/src/main/java/org/apache/iotdb/commons/client/internal/subscription/InternalSubscriptionTablePullConsumerBuilder.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Line is longer than 100 characters (found 109).

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AaHJlSj5om8Y9z6JBCBU&open=AaHJlSj5om8Y9z6JBCBU&pullRequest=19222

Check warning on line 233 in iotdb-core/confignode/src/main/java/org/apache/iotdb/confignode/conf/ConfigNodeStartupCheck.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Expected @throws tag for 'ConfigurationException'.

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AaHJlWwZom8Y9z6JBCCC&open=AaHJlWwZom8Y9z6JBCCC&pullRequest=19222

Check warning on line 65 in iotdb-client/subscription/src/main/java/org/apache/iotdb/session/subscription/SubscriptionTreeSessionBuilder.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Abbreviation in name 'useSSL' must contain no more than '2' consecutive capital letters.

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AaHJlXIfom8Y9z6JBCCQ&open=AaHJlXIfom8Y9z6JBCCQ&pullRequest=19222

Check warning on line 959 in iotdb-core/datanode/src/main/java/org/apache/iotdb/db/subscription/broker/consensus/ConsensusSubscriptionCommitManager.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

WhitespaceAround: '{' is not followed by whitespace. Empty blocks may only be represented as {} when not part of a multi-block statement (4.1.3)

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AaHJlVeoom8Y9z6JBCB0&open=AaHJlVeoom8Y9z6JBCB0&pullRequest=19222

Check warning on line 959 in iotdb-core/datanode/src/main/java/org/apache/iotdb/db/subscription/broker/consensus/ConsensusSubscriptionCommitManager.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

WhitespaceAround: '}' is not preceded with whitespace.

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AaHJlVeoom8Y9z6JBCB1&open=AaHJlVeoom8Y9z6JBCB1&pullRequest=19222

Check warning on line 187 in iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/statement/crud/InsertRowsOfOneDeviceStatement.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace this usage of 'Stream.collect(Collectors.toList())' with 'Stream.toList()' and ensure that the list is unmodified.

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AaHJlT6lom8Y9z6JBCBr&open=AaHJlT6lom8Y9z6JBCBr&pullRequest=19222

Check failure on line 561 in iotdb-core/datanode/src/main/java/org/apache/iotdb/db/subscription/receiver/SubscriptionReceiverV1.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor this method to reduce its Cognitive Complexity from 21 to the 15 allowed.

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AaHJlVh-om8Y9z6JBCB2&open=AaHJlVh-om8Y9z6JBCB2&pullRequest=19222

Check warning on line 52 in iotdb-core/datanode/src/main/java/org/apache/iotdb/db/protocol/thrift/InternalClientRPCServiceProcessor.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Abbreviation in name 'InternalClientRPCServiceProcessor' must contain no more than '2' consecutive capital letters.

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AaHJlU4vom8Y9z6JBCBw&open=AaHJlU4vom8Y9z6JBCBw&pullRequest=19222

Check warning on line 38 in iotdb-core/node-commons/src/main/java/org/apache/iotdb/commons/client/internal/session/InternalTableSessionPoolBuilder.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

'}' at column 45 should be alone on a line.

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AaHJlSjMom8Y9z6JBCBQ&open=AaHJlSjMom8Y9z6JBCBQ&pullRequest=19222

Check warning on line 82 in iotdb-core/node-commons/src/main/java/org/apache/iotdb/commons/disk/FolderManager.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Expected @throws tag for 'DiskSpaceInsufficientException'.

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AaHJlSpCom8Y9z6JBCBV&open=AaHJlSpCom8Y9z6JBCBV&pullRequest=19222

Check warning on line 256 in iotdb-core/datanode/src/main/java/org/apache/iotdb/db/storageengine/rescon/disk/TierManager.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Move this method into "TierFolderManager".

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AaHJlTPDom8Y9z6JBCBf&open=AaHJlTPDom8Y9z6JBCBf&pullRequest=19222

Check warning on line 181 in iotdb-client/subscription/src/main/java/org/apache/iotdb/session/subscription/consumer/base/AbstractSubscriptionConsumerBuilder.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Abbreviation in name 'useSSL' must contain no more than '2' consecutive capital letters.

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AaHJlXBuom8Y9z6JBCCJ&open=AaHJlXBuom8Y9z6JBCCJ&pullRequest=19222

Check warning on line 136 in iotdb-client/subscription/src/main/java/org/apache/iotdb/session/subscription/consumer/tree/SubscriptionTreePushConsumerBuilder.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Abbreviation in name 'useSSL' must contain no more than '2' consecutive capital letters.

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AaHJlXFvom8Y9z6JBCCN&open=AaHJlXFvom8Y9z6JBCCN&pullRequest=19222

Check warning on line 1088 in iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/relational/analyzer/StatementAnalyzer.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Line is longer than 100 characters (found 118).

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AaHJlTkrom8Y9z6JBCBg&open=AaHJlTkrom8Y9z6JBCBg&pullRequest=19222

Check warning on line 136 in iotdb-client/subscription/src/main/java/org/apache/iotdb/session/subscription/consumer/table/SubscriptionTablePushConsumerBuilder.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Abbreviation in name 'useSSL' must contain no more than '2' consecutive capital letters.

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AaHJlW47om8Y9z6JBCCG&open=AaHJlW47om8Y9z6JBCCG&pullRequest=19222

Check warning on line 1981 in iotdb-core/confignode/src/main/java/org/apache/iotdb/confignode/manager/ConfigManager.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Line is longer than 100 characters (found 115).

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AaHJlWX2om8Y9z6JBCB7&open=AaHJlWX2om8Y9z6JBCB7&pullRequest=19222

Check warning on line 23 in iotdb-core/datanode/src/main/java/org/apache/iotdb/db/protocol/thrift/impl/InternalClientRPCServiceImpl.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Abbreviation in name 'InternalClientRPCServiceImpl' must contain no more than '2' consecutive capital letters.

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AaHJlUx3om8Y9z6JBCBv&open=AaHJlUx3om8Y9z6JBCBv&pullRequest=19222