Repository navigation
Conversation
|
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #19222 +/- ##
============================================
+ Coverage 48.87% 48.89% +0.01%
Complexity 689 689
============================================
Files 5588 5589 +1
Lines 413425 413479 +54
Branches 54525 54547 +22
============================================
+ Hits 202074 202156 +82
+ Misses 211351 211323 -28 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.




Description
Unsubscribe fails when metadata pushes encounter an unavailable registered DataNode. Allow unsubscribe execution and rollback to tolerate explicitly marked transport failures only when the DataNode is
UnknownorStopped. Keep metadata rejections, protocol/application errors, local dispatch errors, and failures from online nodes as failures. Other consumer-group operations retain their existing failure semantics.For example, with consumer
cin groupgsubscribed to topict, stop DN2 and wait until it is marked offline, then unsubscribecfromt. Previously, a connection failure while dropping the subscription Pipe or updating the consumer group caused unsubscribe to fail. With this change, unsubscribe can complete on the available nodes; DN2 receives the current metadata through the existing synchronization path after reconnecting. Failed consumer-group pushes are recorded by the ready tracker before transport failures are filtered.Validation
master.This PR has:
Key changed/added classes
DataNodeTransportFailureUtils,PipePushMetaRPCHandler,ConsumerGroupPushMetaRPCHandler,ConfigNodeProcedureEnv,AlterConsumerGroupProcedure, andDropSubscriptionProcedure.