Name an exposure after the entity serving it - #183
Merged
Conversation
Superseded by the environment's agent_runtime_image_id. Nothing reads it: the orchestrator refuses a workload whose environment names no runtime rather than substituting the agent's own image (agynio/agents-orchestrator, remove the legacy init container).
The Exposure record was agent-shaped -- agent_id, and nothing else -- while sandboxes have exposed ports since they existed. It takes owner_kind and owner_id, matching the generalization runners.Workload already made, plus the organization and the resolved hostname the intercept.v1 config is written from. agent_id stays for agent-instance owners and is marked deprecated; on AddExposureRequest it is accepted and ignored, since the owner is read from the workload record rather than asserted by the caller. The owner-kind enum is restated here rather than imported from runners: domain packages in this module do not depend on one another, and the values match so neither side needs translating.
|
The latest Buf updates on your PR. Results from workflow buf-pr / buf (pull_request).
|
This was referenced Aug 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
Exposurerecord is agent-shaped —agent_id, and nothing else — while sandboxes have exposed ports since they existed.It takes
owner_kindandowner_id, matching the generalizationrunners.Workloadalready made, plus the organization and the resolvedhostnametheintercept.v1config is written from. An exposed port becomes reachable atsuper-sandbox.acme.agyn:3000orresearch.bob.acme.agyn:3000rather thanexposed-<uuid>.agyn:3000.agent_idstays for agent-instance owners and is marked deprecated; onAddExposureRequestit is accepted and ignored, since the owner is read from the workload record rather than asserted by the caller.The owner-kind enum is restated here rather than imported from
runners: domain packages in this module do not depend on one another, and the values match so neither side needs translating.buf lintandbuf breakingagainstmainare both clean.Spec:
agynio/architecturechange doc2026-08-10-entity-named-port-exposure.md.