Drop the prose I put in expose.proto - #185
Merged
Merged
Conversation
Documentation belongs in the architecture repo, not in the wire contract. The field and enum comments added with the entity-named exposure change restated what the spec already says -- how a hostname is derived, when it falls back, what an owner resolves to -- and a proto that carries that prose goes stale the moment the spec moves. What stays is structural: the deprecation markers, and the pre-existing rpc comments with "agent workload" corrected to "workload", since a sandbox exposes ports too.
|
The latest Buf updates on your PR. Results from workflow buf-pr / buf (pull_request).
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #183.
Documentation belongs in the architecture repo, not in the wire contract. The field and enum comments that landed with the entity-named exposure change restated what the spec already says — how a hostname is derived, when it falls back to the opaque form, what an owner resolves to, why the owner-kind enum is not imported from
runners. A proto carrying that prose goes stale the moment the spec moves, and there are now two places to read for one answer.Removed: every comment #183 added.
Kept: the deprecation markers, which are structural, and the pre-existing rpc comments — with
agent workloadcorrected toworkload, since a sandbox exposes ports too.No wire change.
buf lintandbuf breakingagainstmainare both clean.