Skip to content

Fix benchmark startup sequence for testing #587

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
camillobruni wants to merge 2 commits into
base: main
Choose a base branch
from
+12 −7
Open

Fix benchmark startup sequence for testing #587

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
65c4805
harden_startup_sequence
camillobruni Aug 31, 2026
a666699
clenaer_event_point
camillobruni Aug 31, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 11 additions & 6 deletions resources/main.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,16 +26,17 @@ class MainBenchmarkClient {
_steppingPromise = null;
_steppingResolver = null;
_benchmarkConfiguratorPromise = null;
_isInitialized = false;

get isInitialized() {

@Andrew-Fryer Andrew-Fryer Sep 22, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit:
Does this need to be a getter instead of just a method like isRunning and hasFinished?

return this._isInitialized;
}

constructor() {
this._benchmarkConfiguratorPromise = import("./benchmark-configurator.mjs");
this.prepareUI();
this.evaluateParams();
this._showSection(window.location.hash);

this._benchmarkConfiguratorPromise.then(() => {
window.dispatchEvent(new Event("SpeedometerReady"));
});
}

isRunning() {
Expand Down Expand Up @@ -389,10 +390,14 @@ class MainBenchmarkClient {
document.body.append(this._developerModeContainer);
}

if (!params.startAutomatically)
this._setBenchmarkState(BENCHMARK_STATE.READY);

this._isInitialized = true;
window.dispatchEvent(new Event("SpeedometerReady"));

if (params.startAutomatically)
this.start();
else
this._setBenchmarkState(BENCHMARK_STATE.READY);
}

async _setBenchmarkState(state) {
Expand Down
2 changes: 1 addition & 1 deletion tests/run-end2end.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ async function testPage(url) {
await driver.get(`http://localhost:${port}/${url}`);

await driver.executeAsyncScript((callback) => {
if (globalThis.benchmarkClient)
if (globalThis.benchmarkClient.isInitialized)
callback();
else
globalThis.addEventListener("SpeedometerReady", () => callback(), { once: true });
Expand Down
Loading