Fix benchmark startup sequence for testing - #587
Open
camillobruni wants to merge 2 commits into
Open
camillobruni wants to merge 2 commits into
camillobruni wants to merge 2 commits into
Conversation
✅ Deploy Preview for webkit-speedometer-preview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Andrew-Fryer
approved these changes
Sep 22, 2026
Andrew-Fryer
left a comment
Andrew-Fryer
left a comment
There was a problem hiding this comment.
This looks good to me. 👍
I like that we won't dispatch "SpeedometerReady" if something in the constructor throws, so there's a bit less risk of silently reporting a wonky benchmark score.
I think it's a bit weird that we dispatch the "SpeedometerReady" from evaluateParams, but we're already calling this.start() from there.
Perhaps we should refactor in a future PR to move these to a callback passed to evaluateParams().then(callback) in the constructor...?
| _benchmarkConfiguratorPromise = null; | ||
| _isInitialized = false; | ||
|
|
||
| get isInitialized() { |
There was a problem hiding this comment.
Nit:
Does this need to be a getter instead of just a method like isRunning and hasFinished?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There could be a race condition between sending the SpeedometerReady and and the testing running installing the event handler. This PR delays sending the SpeedometerReady event to a later async point in the
evaluateParamsmethod..