Repository navigation
Let an app's owner make it public without approval - #12
Merged
Merged
Conversation
public: true in platform.yaml now opens an app on its own: the PUBLIC_APPS list and its check are gone, along with the bizops portal page that was to edit it. Hosting again with public: false puts the app back behind sign-in. The checker still warns about public: true, and the guide tells Claude to set it only when the user asks for an app outside Virtuals can use. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #11. That PR was merged before its second commit landed, so
mainnow refuses to host any app withpublic: trueunless it's in thePUBLIC_APPSvariable. That variable was never created, so today no app can be hosted as public, acp-ticket-cms included. Apps already running and deploys aren't affected.With this PR,
public: truein an app'splatform.yamlis enough on its own. It's the owner's call:public: trueopens the app. Hosting again withpublic: falseputs it back behind sign-in. Deploys leave access as it is.PUBLIC_APPScheck is removed fromscripts/read-platform.shandhost-app.yml.public: true. The guide (SKILL.md) tells Claude to set it only when the user asks for an app people outside Virtuals can use, and to flag it in the hand-off. Public apps are no longer on the list of things that need the platform team. The plugin version goes to 1.2.0.accesslabel shows which apps are public, and thegcloudcommand that shuts one at once.The bizops portal page that was to edit the list (Virtual-Protocol/internal-bizops-tool#126) is closed. Nothing needs setting up before merging.
Security note
Any app owner can now open their app to the internet. The checks that stay: the repo must be private and in Virtual-Protocol, and the person hosting must be the owner named in
platform.yaml. Public apps still don't grant anything toallUsers, because they only turn off Cloud Run's invoker check.Testing
Ran
read-platform.shlocally with ayqstand-in.public: truewith no list givespublic=true;public: false, nopublickey, and a non-boolean value all givepublic=false. The scripts passbash -n, both workflows parse, and the plugin's copies match their originals.🤖 Generated with Claude Code