Skip to content

Approve public apps from the bizops portal instead of public-apps.txt - #11

Merged
psmiratisu merged 1 commit into
mainfrom
miratisu/public-app-approval-config-28ccce
Nov 17, 2026
Merged

psmiratisu merged 1 commit into
mainfrom
miratisu/public-app-approval-config-28ccce

Conversation

@psmiratisu

@psmiratisu psmiratisu commented Nov 17, 2026 •

Copy link
Copy Markdown
Contributor

Replaced by #12. We decided public apps don't need approval. This PR was merged before that change landed, so on its own it leaves main refusing every public: true app, because PUBLIC_APPS was never created.

What this merged

The approved public apps moved from public-apps.txt to this repo's PUBLIC_APPS Actions variable, a JSON list of {name, repo, approvedBy, approvedAt}. host-app.yml passes it to scripts/read-platform.sh, which hosts a public: true app only when both its name and its repo are in the list. A missing or broken list approves nothing. public-apps.txt was deleted, and the README, checker message and templates were updated to match. A bizops portal page was planned to edit the list (Virtual-Protocol/internal-bizops-tool#126, now closed).

🤖 Generated with Claude Code

Approving an app to be public meant a reviewed change to public-apps.txt on
main. The approved list is now this repo's PUBLIC_APPS Actions variable, a
JSON list of {name, repo, approvedBy, approvedAt}, which the bizops portal's
Tech help > Public apps page edits through its GitHub token. host-app.yml
reads it on every run, so approving takes effect on the app's next hosting
run, with no change or deploy here.

read-platform.sh still needs both the app's name and its repo to match, and
a missing or broken list approves nothing. Taking an approval away stops the
app being hosted as public again but doesn't close an app already open; the
README says how to close one.

Before merging, PUBLIC_APPS must hold acp-ticket-cms, or hosting it again
would be refused (deploys are unaffected).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@psmiratisu
psmiratisu merged commit ae854a0 into main Nov 17, 2026
1 check passed
@psmiratisu psmiratisu changed the title Approve public apps from the bizops portal instead of public-apps.txt Let an app's owner make it public without approval Nov 17, 2026
@psmiratisu psmiratisu changed the title Let an app's owner make it public without approval Approve public apps from the bizops portal instead of public-apps.txt Nov 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant