Skip to content

Send the delayed potion spawn's velocity as its own packet in 1.9->1.8 #722

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Term4 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Send the delayed potion spawn's velocity as its own packet in 1.9->1.8 #722

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions ...in/java/com/viaversion/viarewind/protocol/v1_9to1_8/rewriter/EntityPacketRewriter1_9.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -604,6 +604,15 @@ private void sendDelayedPotionSpawn(final EntityDataHandlerEvent event, final En
addEntity.write(Types.SHORT, spawn.velocityY());
addEntity.write(Types.SHORT, spawn.velocityZ());
addEntity.send(Protocol1_9To1_8.class); // Before the entity data is sent

// 1.8 clients never apply a potion spawn's velocity - vanilla servers send it in a separate
// velocity packet after the spawn, so do the same
final PacketWrapper setEntityMotion = PacketWrapper.create(ClientboundPackets1_8.SET_ENTITY_MOTION, event.user());
setEntityMotion.write(Types.VAR_INT, event.entityId());
setEntityMotion.write(Types.SHORT, spawn.velocityX());
setEntityMotion.write(Types.SHORT, spawn.velocityY());
setEntityMotion.write(Types.SHORT, spawn.velocityZ());
setEntityMotion.send(Protocol1_9To1_8.class);
}

private void handleEntityData(EntityDataHandlerEvent event, EntityData entityData) {
Expand Down