Send the delayed potion spawn's velocity as its own packet in 1.9->1.8 - #722
Open
Term4 wants to merge 1 commit into
Open
Send the delayed potion spawn's velocity as its own packet in 1.9->1.8#722Term4 wants to merge 1 commit into
Term4 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Didn't notice this before since I was using patcher in testing (which fixed this issue), but pre 1.9 vanilla clients never apply a potion spawn's velocity (due to how they're spawned in). NetHandlerPlayClient.handleSpawnObject zeroes the data before the generic data > 0 → setVelocity, so the shorts in the spawn packet are dropped. A vanilla server sends the arc in a separate velocity packet after the spawn (EntityTrackerEntry), which is why the data <= 0 branch here already does exactly that.
Since #703 holds the potion spawn back and folds any incoming SET_ENTITY_MOTION into it, that packet is currently lost for every 1.9+ server.
This re-sends the held velocity as its own packet right after the delayed spawn, matching both the vanilla tracker and the existing data <= 0 path. Tested on 1.8.9 vanilla, lunar, badlion, and forge with & without patcher.