Skip to content

test: Rewrite TransformInterpolationTests to remove its random failures - up-port - #4148

Open
NoelStephensUnity wants to merge 2 commits into
develop-3.x.xfrom
fix/test/transforminterpolationtests-random-failures-up-port
Open

test: Rewrite TransformInterpolationTests to remove its random failures - up-port#4148
NoelStephensUnity wants to merge 2 commits into
develop-3.x.xfrom
fix/test/transforminterpolationtests-random-failures-up-port

Conversation

@NoelStephensUnity

@NoelStephensUnity NoelStephensUnity commented Aug 27, 2026

Copy link
Copy Markdown
Member

Purpose of this PR

Up-port of #4147

Overhauling this test since it has been problematic for a long time. The root cause is that the values applied ended forming a discontinuously-linear/saw-tooth motion which makes it very problematic to distinguish a fault from an actual valid interpolation.

The actual solution is to use a smoothed sinusoidal wave that forms a continuous motion that is discernable between a fault and the motion being applied.

Jira ticket

(Link ticket here)

Changelog

NA

Documentation

  • No documentation changes or additions were necessary.

Testing & QA (How your changes can be verified during release Playtest)

Functional Testing

Manual testing :

  • Manual testing done

Automated tests:

  • Covered by the adjustments made to TransformInterpolationTest.
  • Covered by new automated tests

Does the change require QA team to:

  • Review automated tests?
  • Execute manual tests?
  • Provide feedback about the PR?

If any boxes above are checked the QA team will be automatically added as a PR reviewer.

Up-port

None

Backports

None.

Overhauling this test since it has been problematic for a long time. The root cause is that the values applied ended forming a discontinuously-linear/saw-tooth motion which makes it very problematic to distinguish a fault from an actual valid interpolation.

The actual solution is to use a smoothed sinusoidal wave that forms a continuous motion that is discernable between a fault and the motion being applied. There were additional order of operation issues that
@NoelStephensUnity
NoelStephensUnity requested a review from a team as a code owner August 27, 2026 13:51

@u-pr u-pr Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Harness Review

LGTM

The new continuous-motion harness improves the signal for ordinary position updates, but its local/world transition path does not exercise interpolation as intended.

Reviewed commit 7422524

🤖 Helpful? 👍/👎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants