test: Rewrite TransformInterpolationTests to remove its random failures - #4147
Merged
NoelStephensUnity merged 1 commit intoAug 27, 2026
Conversation
Overhauling this test since it has been problematic for a long time. The root cause is that the values applied ended forming a discontinuously-linear/saw-tooth motion which makes it very problematic to distinguish a fault from an actual valid interpolation. The actual solution is to use a smoothed sinusoidal wave that forms a continuous motion that is discernable between a fault and the motion being applied. There were additional order of operation issues that
![u-pr[bot]](https://avatars.githubusercontent.com/in/1201017?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Harness Review
The rewritten integration test drives continuous authority motion through repeated transform-space transitions and validates the non-authority’s sampled world position. I examined its spawn/parenting flow, Host and distributed-authority fixture behavior, and the NetworkTransform update lifecycle.
Reviewed commit d53463f
🤖 Helpful? 👍/👎
Codecov ReportAll modified and coverable lines are covered by tests ✅ @@ Coverage Diff @@
## develop-2.0.0 #4147 +/- ##
=================================================
- Coverage 73.95% 73.88% -0.08%
=================================================
Files 172 172
Lines 28105 28105
=================================================
- Hits 20785 20765 -20
- Misses 7320 7340 +20
Flags with carried forward coverage won't be shown. Click here to find out more. see 1 file with indirect coverage changes
|
michalChrobot
approved these changes
Aug 27, 2026
michalChrobot
left a comment
michalChrobot
left a comment
Member
There was a problem hiding this comment.
LGTM, we can just run this like 5 times to see if it's stable
6 tasks
NoelStephensUnity
deleted the
fix/test/transforminterpolationtests-random-failures
branch
August 27, 2026 14:11
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose of this PR
Overhauling this test since it has been problematic for a long time. The root cause is that the values applied ended forming a discontinuously-linear/saw-tooth motion which makes it very problematic to distinguish a fault from an actual valid interpolation.
The actual solution is to use a smoothed sinusoidal wave that forms a continuous motion that is discernable between a fault and the motion being applied.
Jira ticket
(Link ticket here)
Changelog
NA
Documentation
Testing & QA (How your changes can be verified during release Playtest)
Functional Testing
Manual testing :
Manual testing doneAutomated tests:
Covered by the adjustments made to TransformInterpolationTest.Covered by new automated testsDoes the change require QA team to:
Review automated tests?Execute manual tests?Provide feedback about the PR?If any boxes above are checked the QA team will be automatically added as a PR reviewer.
Up-port
Up-port: #4148
Up-port is required.
Backports
None.