Updated gha to run from main for deploy - #142
Merged
Merged
Conversation
Lextuga007
requested review from
francisbarton and
tomjemmett
as code owners
September 28, 2026 15:02
tomjemmett
requested changes
Sep 28, 2026
tomjemmett
left a comment
tomjemmett
left a comment
Member
There was a problem hiding this comment.
I don't think the target is quite right here - I would go with just
on:
push:
branches: [main]
and possibly include workflow_dispatch:, but that would be more useful if you could do a dev deployment to another location.
That will then get rid of the change made to the deploy step to add the if action
tomjemmett
approved these changes
Sep 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.