Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ abstract class EncryptionAlgorithmCheckSample {
static final String NO_PADDING = "/NONE/NoPadding";
static final String RSA_NO_PADDING = RSA + NO_PADDING;
//^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^>
static final String AES_WRAP = "AESWrap";

public void foo(java.util.Properties props) {
/*
Expand Down Expand Up @@ -93,6 +94,26 @@ public void foo(java.util.Properties props) {
Cipher.getInstance(algoUpperCase); // Noncompliant
// ^^^^^^^^^^^^^

Cipher.getInstance("AESWrap"); // Compliant
Cipher.getInstance(AES_WRAP); // Compliant
Cipher.getInstance("AESWrap_128"); // Compliant
Cipher.getInstance("AESWrap_192"); // Compliant
Cipher.getInstance("AESWrap_256"); // Compliant
Cipher.getInstance("AESWrapPad"); // Compliant
Cipher.getInstance("AESWrapPad_128"); // Compliant
Cipher.getInstance("AESWrapPad_192"); // Compliant
Cipher.getInstance("AESWrapPad_256"); // Compliant
Cipher.getInstance("AES/KW/NoPadding"); // Compliant
Cipher.getInstance("AES/KWP/NoPadding"); // Compliant
Cipher.getInstance("aeswrap"); // Compliant
Cipher.getInstance("AESWRAP_128"); // Compliant
Cipher.getInstance("aesWrapPad_256"); // Compliant
Cipher.getInstance("AESWrap/ECB/NoPadding"); // Compliant
Cipher.getInstance("aeswrap/ecb/nopadding"); // Compliant
Cipher.getInstance("AESWrapPad/KWP/NoPadding"); // Compliant
Cipher.getInstance("AESWrap_64"); // Noncompliant
Cipher.getInstance("AESWrap_64/ECB/NoPadding"); // Noncompliant

} catch (Exception e) {
}
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,8 @@ public class EncryptionAlgorithmCheck extends AbstractMethodDetection {

private static final Pattern ALGORITHM_PATTERN = Pattern.compile("([^/]+)/([^/]+)/([^/]+)");

private static final Pattern KEY_WRAP_PATTERN = Pattern.compile("AESWrap(Pad)?(_(128|192|256))?", Pattern.CASE_INSENSITIVE);
Comment thread
gitar-bot[bot] marked this conversation as resolved.
Resolved

@Override
protected MethodMatchers getMethodInvocationMatchers() {
return MethodMatchers.create()
Expand Down Expand Up @@ -77,9 +79,15 @@ protected void onMethodInvocationFound(MethodInvocationTree mit) {
}

private static Optional<String> getInsecureAlgorithmMessage(String algorithmName) {
if (KEY_WRAP_PATTERN.matcher(algorithmName).matches()) {
return Optional.empty();
}
Matcher matcher = ALGORITHM_PATTERN.matcher(algorithmName);
if (matcher.matches()) {
String algorithm = matcher.group(1);
if (KEY_WRAP_PATTERN.matcher(algorithm).matches()) {
return Optional.empty();
}
String mode = matcher.group(2);
String padding = matcher.group(3);

Expand Down
Loading