Repository navigation
Expand file tree
/
Copy pathEncryptionAlgorithmCheckSample.java
More file actions
123 lines (100 loc) · 5.38 KB
/
Copy pathEncryptionAlgorithmCheckSample.java
File metadata and controls
123 lines (100 loc) · 5.38 KB
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
package checks.security;
import javax.crypto.Cipher;
import static java.io.File.separator;
abstract class EncryptionAlgorithmCheckSample {
static final String RSA = "RSA";
static final String NO_PADDING = "/NONE/NoPadding";
static final String RSA_NO_PADDING = RSA + NO_PADDING;
//^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^>
static final String AES_WRAP = "AESWrap";
public void foo(java.util.Properties props) {
/*
should complain:
- everytime ECB mode is used
- By default without specifying operation mode ECB is chosen
- when CBC mode is used with padding different from "NoPadding"
- when RSA is used without OAEPWithSHA-1AndMGF1Padding or OAEPWITHSHA-256ANDMGF1PADDING padding scheme
*/
try {
Cipher.getInstance(RSA_NO_PADDING); // Noncompliant
// ^^^^^^^^^^^^^^
// First case
Cipher.getInstance("AES"); // Noncompliant {{Use a secure padding scheme.}}
// ^^^^^
Cipher.getInstance("AES/ECB/NoPadding"); // Noncompliant {{Use a secure cipher mode.}}
Cipher.getInstance("AES" + "/ECB/NoPadding"); // Noncompliant
Cipher.getInstance("AES/ECB/NoPadding", getProvider()); // Noncompliant
Cipher.getInstance("AES/ECB/NoPadding", "someProvider"); // Noncompliant
Cipher.getInstance("Blowfish/ECB/PKCS5Padding"); // Noncompliant {{Use a secure cipher mode.}}
Cipher.getInstance("DES/ECB/PKCS5Padding"); // Noncompliant
Cipher.getInstance("AES/GCM/NoPadding"); // Compliant
// Second case
Cipher.getInstance("AES/CBC/PKCS5Padding"); // Noncompliant {{Use another cipher mode or disable padding.}}
Cipher.getInstance("Blowfish/CBC/PKCS5Padding"); // Noncompliant
Cipher.getInstance("DES/CBC/PKCS5Padding"); // Noncompliant
Cipher.getInstance("AES/CBC/PKCS7Padding"); // Noncompliant
Cipher.getInstance("Blowfish/CBC/PKCS7Padding"); // Noncompliant
Cipher.getInstance("DES/CBC/PKCS7Padding"); // Noncompliant
Cipher.getInstance("DES/CBC/NoPadding"); // Compliant
Cipher.getInstance("AES/GCM/NoPadding"); // Compliant
Cipher.getInstance("Blowfish/GCM/NoPadding"); // Compliant
// Third case
Cipher.getInstance("RSA/NONE/NoPadding"); // Noncompliant {{Use a secure padding scheme.}}
Cipher.getInstance("RSA/GCM/NoPadding"); // Noncompliant
Cipher.getInstance("RSA/ECB/NoPadding"); // Noncompliant
// SUN Security Provider (default for openjdk 11 for example) treats ECB as None
Cipher.getInstance("RSA/ECB/OAEPWithSHA-1AndMGF1Padding"); // Compliant
Cipher.getInstance("RSA/NONE/OAEPWithSHA-1AndMGF1Padding"); // Compliant
Cipher.getInstance("RSA/NONE/OAEPWITHSHA-256ANDMGF1PADDING"); // Compliant
Cipher.getInstance("RSA/None/OAEPWITHSHA-384ANDMGF1PADDING"); // Compliant
Cipher.getInstance("RSA/None/OAEPWITHSHA-512ANDMGF1PADDING"); // Compliant
// Other
Cipher.getInstance(null); // Compliant
Cipher.getInstance(""); // Noncompliant
String algo = props.getProperty("myAlgo", "AES/ECB/PKCS5Padding");
// ^^^^^^^^^^^^^^^^^^^^^^>
Cipher.getInstance(algo); // Noncompliant
// ^^^^
String s = "RSA/NONE/NoPadding"; // Compliant
// ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^>
Cipher.getInstance(s); // Noncompliant
// ^
String sPlus = "RSA" + "/NONE/NoPadding"; // Compliant
// ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^>
Cipher.getInstance(sPlus); // Noncompliant
// ^^^^^
Cipher.getInstance(separator); // Compliant, can not resolve the declaration, for coverage
// Case is ignored
Cipher.getInstance("rsa/None/NoPadding"); // Noncompliant
Cipher.getInstance("AES/ecb/NoPadding"); // Noncompliant
Cipher.getInstance("aes/GCM/NoPadding"); // Compliant
Cipher.getInstance("DES/CBC/NOPADDING"); // Compliant
Cipher.getInstance("RSA/NONE/OAEPWITHSHA-1AndMGF1Padding"); // Compliant
String algoUpperCase = props.getProperty("myAlgo", "AES/ECB/PKCS5PADDING");
// ^^^^^^^^^^^^^^^^^^^^^^>
Cipher.getInstance(algoUpperCase); // Noncompliant
// ^^^^^^^^^^^^^
Cipher.getInstance("AESWrap"); // Compliant
Cipher.getInstance(AES_WRAP); // Compliant
Cipher.getInstance("AESWrap_128"); // Compliant
Cipher.getInstance("AESWrap_192"); // Compliant
Cipher.getInstance("AESWrap_256"); // Compliant
Cipher.getInstance("AESWrapPad"); // Compliant
Cipher.getInstance("AESWrapPad_128"); // Compliant
Cipher.getInstance("AESWrapPad_192"); // Compliant
Cipher.getInstance("AESWrapPad_256"); // Compliant
Cipher.getInstance("AES/KW/NoPadding"); // Compliant
Cipher.getInstance("AES/KWP/NoPadding"); // Compliant
Cipher.getInstance("aeswrap"); // Compliant
Cipher.getInstance("AESWRAP_128"); // Compliant
Cipher.getInstance("aesWrapPad_256"); // Compliant
Cipher.getInstance("AESWrap/ECB/NoPadding"); // Compliant
Cipher.getInstance("aeswrap/ecb/nopadding"); // Compliant
Cipher.getInstance("AESWrapPad/KWP/NoPadding"); // Compliant
Cipher.getInstance("AESWrap_64"); // Noncompliant
Cipher.getInstance("AESWrap_64/ECB/NoPadding"); // Noncompliant
} catch (Exception e) {
}
}
abstract java.security.Provider getProvider();
}