Repository navigation
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Breaks when either this PR or SonarSource/renovate-config#187 merges before the other, so the next Renovate run on sonar-java cannot find its preset.
How
.github/renovate.json:4extendsgithub>SonarSource/renovate-config:quality-analysis-platform-squad, and Renovate looks upquality-analysis-platform-squad.jsonon renovate-config's default branch.masteryet. It is only added by the counterpart, atquality-analysis-platform-squad.json:1.quality-corelang-squad.jsonrather than copying it. So if it merges first, the currentquality-corelang-squadreference here stops resolving too.CONFIG_VALIDATIONerror ("Cannot find preset's package") and stops creating update PRs for the repo until the config is fixed.Fix
master.quality-corelang-squad.jsonas a thin alias that extendslocal>SonarSource/renovate-config:quality-analysis-platform-squaduntil all consumers have switched, so either merge order is safe.Compared
ed1dd5cwith SonarSource/renovate-config#187 at4894218Was this helpful? React with 👍 / 👎