Skip to content

AP-1393 Use Analysis Platform Renovate preset - #6502

Merged
BartLucien merged 1 commit into
masterfrom
lb/AP1384-analysis-platform-renovate
Nov 11, 2026
Merged

BartLucien merged 1 commit into
masterfrom
lb/AP1384-analysis-platform-renovate

Conversation

@BartLucien

Copy link
Copy Markdown
Contributor

Part of AP-1384

@hashicorp-vault-sonar-prod hashicorp-vault-sonar-prod Bot changed the title Use Analysis Platform Renovate preset AP-1393 Use Analysis Platform Renovate preset Nov 11, 2026
@hashicorp-vault-sonar-prod

hashicorp-vault-sonar-prod Bot commented Nov 11, 2026 •

Copy link
Copy Markdown
Contributor

AP-1393

@gitar-bot

gitar-bot Bot commented Nov 11, 2026 •

Copy link
Copy Markdown
Code Review ⚠️ Changes requested 🟡 Medium risk 0 closed / 1 findings

Switching Renovate presets changes dependency-update rules, which could alter update PRs or leave relevant dependencies unmanaged.

Switches the Renovate config to the Analysis Platform preset quality-analysis-platform-squad, but the change has an open important finding. Renovate will fail to resolve the preset until SonarSource/renovate-config#187 is on master, and merging in the wrong order would break update PRs for the repo. Merge only after the counterpart lands, or keep quality-corelang-squad.json as an alias in that PR.

⚠️ Cross-PR: Renovate config breaks while preset rename is half-merged · SonarSource/renovate-config #187

📄 .github/renovate.json:4

Breaks when either this PR or SonarSource/renovate-config#187 merges before the other, so the next Renovate run on sonar-java cannot find its preset.

How

  1. .github/renovate.json:4 extends github>SonarSource/renovate-config:quality-analysis-platform-squad, and Renovate looks up quality-analysis-platform-squad.json on renovate-config's default branch.
  2. That file does not exist on master yet. It is only added by the counterpart, at quality-analysis-platform-squad.json:1.
  3. The counterpart renames quality-corelang-squad.json rather than copying it. So if it merges first, the current quality-corelang-squad reference here stops resolving too.
  4. When a named preset is missing, Renovate raises a CONFIG_VALIDATION error ("Cannot find preset's package") and stops creating update PRs for the repo until the config is fixed.

Fix

Compared ed1dd5c with SonarSource/renovate-config#187 at 4894218

🤖 Prompt for agents
Code Review: Switches the Renovate config to the Analysis Platform preset `quality-analysis-platform-squad`, but the change has an open important finding. Renovate will fail to resolve the preset until SonarSource/renovate-config#187 is on `master`, and merging in the wrong order would break update PRs for the repo. Merge only after the counterpart lands, or keep `quality-corelang-squad.json` as an alias in that PR.

1. ⚠️ Cross-PR: Renovate config breaks while preset rename is half-merged · [SonarSource/renovate-config #187](<https://github.com/SonarSource/renovate-config/pull/187>)
   Files: .github/renovate.json:4

   **Breaks when** either this PR or [SonarSource/renovate-config#187](<https://github.com/SonarSource/renovate-config/pull/187>) merges before the other, so the next Renovate run on sonar-java cannot find its preset.
   
   **How**
   
   1. `.github/renovate.json:4` extends `github>SonarSource/renovate-config:quality-analysis-platform-squad`, and Renovate looks up `quality-analysis-platform-squad.json` on renovate-config's default branch.
   2. That file does not exist on `master` yet. It is only added by the counterpart, at `quality-analysis-platform-squad.json:1`.
   3. The counterpart renames `quality-corelang-squad.json` rather than copying it. So if it merges first, the current `quality-corelang-squad` reference here stops resolving too.
   4. When a named preset is missing, Renovate raises a `CONFIG_VALIDATION` error ("Cannot find preset's package") and stops creating update PRs for the repo until the config is fixed.
   
   **Fix**
   
   - **This PR:** Merge only after [SonarSource/renovate-config#187](<https://github.com/SonarSource/renovate-config/pull/187>) is on `master`.
   - **[SonarSource/renovate-config#187](<https://github.com/SonarSource/renovate-config/pull/187>):** Keep `quality-corelang-squad.json` as a thin alias that extends `local>SonarSource/renovate-config:quality-analysis-platform-squad` until all consumers have switched, so either merge order is safe.
   
   _Compared `ed1dd5c` with [SonarSource/renovate-config#187](<https://github.com/SonarSource/renovate-config/pull/187>) at `4894218`_

Verification Rules 2/2 met PRs 1 inspected

Functional validation No results

Rules 2 passed 1 not applicable

✅ Internal artifact registries
✅ Repository license compliance

Broader impact PRs 1 inspected
Cross-PR 1 PR inspected 1 open impact

PR 187: AP-1385 Create config for analysis platform Inspected

Auto-approval Not enabled

Set up

For more verification details, comment gitar display:verbose.

Options

Auto-apply is off → Gitar will not commit updates to this branch.
Display: compact → Showing compact verification results.
Unblock → Override a blocking verdict and allow merging.

Comment with these commands to change the behavior for this request:

Auto-apply Compact Unblock
gitar auto-apply:on         
gitar display:verbose         
gitar unblock         

Was this helpful? React with 👍 / 👎 | Gitar

Comment thread .github/renovate.json
"$schema": "https://docs.renovatebot.com/renovate-schema.json",
"extends": [
"github>SonarSource/renovate-config:quality-corelang-squad"
"github>SonarSource/renovate-config:quality-analysis-platform-squad"

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Cross-PR: Renovate config breaks while preset rename is half-merged · SonarSource/renovate-config #187

Breaks when either this PR or SonarSource/renovate-config#187 merges before the other, so the next Renovate run on sonar-java cannot find its preset.

How

  1. .github/renovate.json:4 extends github>SonarSource/renovate-config:quality-analysis-platform-squad, and Renovate looks up quality-analysis-platform-squad.json on renovate-config's default branch.
  2. That file does not exist on master yet. It is only added by the counterpart, at quality-analysis-platform-squad.json:1.
  3. The counterpart renames quality-corelang-squad.json rather than copying it. So if it merges first, the current quality-corelang-squad reference here stops resolving too.
  4. When a named preset is missing, Renovate raises a CONFIG_VALIDATION error ("Cannot find preset's package") and stops creating update PRs for the repo until the config is fixed.

Fix

Compared ed1dd5c with SonarSource/renovate-config#187 at 4894218

Was this helpful? React with 👍 / 👎

@sonarqube-next

Copy link
Copy Markdown
Contributor

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
0 Dependency risks
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@aurelien-coet-sonarsource aurelien-coet-sonarsource left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BartLucien
BartLucien merged commit 4cb0da3 into master Nov 11, 2026
21 checks passed
@BartLucien
BartLucien deleted the lb/AP1384-analysis-platform-renovate branch November 11, 2026 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants