Repository navigation
AP-1393 Use Analysis Platform Renovate preset - #6502
Conversation
Code Review
|
| Auto-apply | Compact | Unblock |
|
|
|
Was this helpful? React with 👍 / 👎 | Gitar
| "$schema": "https://docs.renovatebot.com/renovate-schema.json", | ||
| "extends": [ | ||
| "github>SonarSource/renovate-config:quality-corelang-squad" | ||
| "github>SonarSource/renovate-config:quality-analysis-platform-squad" |
There was a problem hiding this comment.
⚠️ Cross-PR: Renovate config breaks while preset rename is half-merged · SonarSource/renovate-config #187
Breaks when either this PR or SonarSource/renovate-config#187 merges before the other, so the next Renovate run on sonar-java cannot find its preset.
How
.github/renovate.json:4extendsgithub>SonarSource/renovate-config:quality-analysis-platform-squad, and Renovate looks upquality-analysis-platform-squad.jsonon renovate-config's default branch.- That file does not exist on
masteryet. It is only added by the counterpart, atquality-analysis-platform-squad.json:1. - The counterpart renames
quality-corelang-squad.jsonrather than copying it. So if it merges first, the currentquality-corelang-squadreference here stops resolving too. - When a named preset is missing, Renovate raises a
CONFIG_VALIDATIONerror ("Cannot find preset's package") and stops creating update PRs for the repo until the config is fixed.
Fix
- This PR: Merge only after SonarSource/renovate-config#187 is on
master. - SonarSource/renovate-config#187: Keep
quality-corelang-squad.jsonas a thin alias that extendslocal>SonarSource/renovate-config:quality-analysis-platform-squaduntil all consumers have switched, so either merge order is safe.
Compared ed1dd5c with SonarSource/renovate-config#187 at 4894218
Was this helpful? React with 👍 / 👎
|





Part of AP-1384