Harden E2E config link prompt submit#8070
Merged
Merged
Conversation
feffe13 to
7638d56
Compare
4 tasks
gonzaloriestra
approved these changes
Jul 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
No issue.
The
app-deployE2E test can fail while creating its secondary app throughapp config link. The helper was sending the generated app name as many tiny PTY writes, which can drop characters under busy CI prompt rendering, and it also treated the captured Ink prompt echo as required for progress.WHAT is this pull request doing?
Writes the app name as one PTY text event, waits briefly for the input to be consumed, and then submits Enter separately so Ink handles Enter as submission. It also avoids waiting for the full app name echo, because Ink line-clearing can make captured prompt output incomplete even when input was received.
How to test your changes?
pnpm --filter @shopify/e2e lint✅cd packages/e2e && pnpm exec tsc --noEmit --project tsconfig.json✅git diff --check✅tests/app-deploy.spec.ts:84passed on this branch.E2E tests (shard 1/2)is still red because the separatedev-hot-reload.spec.ts:42invalid-config failure remains onmain; that is fixed separately in Keep hot reload E2E scopes valid #8069.Not run locally: credentialed Playwright E2E. I also tried
pnpm --filter @shopify/e2e type-check, but it currently fails before this diff onorigin/maindue unrelated@shopify/organizations/Organizationtype resolution errors inappandstorebuilds.Post-release steps
None.
Checklist
patchfor bug fixes ·minorfor new features ·majorfor breaking changes) and added a changeset withpnpm changeset addNot user-facing; no changeset added.