Skip to content

Keep hot reload E2E scopes valid#8069

Merged
alfonso-noriega merged 1 commit into
mainfrom
maintenance/hot-reload-valid-scopes
Jul 13, 2026
Merged

Keep hot reload E2E scopes valid#8069
alfonso-noriega merged 1 commit into
mainfrom
maintenance/hot-reload-valid-scopes

Conversation

@alfonso-noriega

@alfonso-noriega alfonso-noriega commented Jul 13, 2026

Copy link
Copy Markdown
Contributor

WHY are these changes introduced?

No issue.

The dev-hot-reload E2E test edits app config to trigger a TOML reload, but mutating access_scopes.scopes can make the fixture invalid because the same fixture includes an orders/create webhook subscription that requires read_orders or read_marketplace_orders. When the dev preview rejects the config, the test times out waiting for Updated dev preview.

WHAT is this pull request doing?

Changes the test to mutate a harmless URL field instead of scopes. This still exercises the TOML reload path without invalidating webhook scope requirements.

How to test your changes?

  • pnpm --filter @shopify/e2e lint
  • cd packages/e2e && pnpm exec tsc --noEmit --project tsconfig.json
  • git diff --check
  • CI follow-up: tests/dev-hot-reload.spec.ts:42 passed on this branch. E2E tests (shard 1/2) is still red because the separate app-deploy.spec.ts:84 config-link failure remains on main; that is fixed separately in Harden E2E config link prompt submit #8070.

Not run locally: credentialed Playwright E2E. I also tried pnpm --filter @shopify/e2e type-check, but it currently fails before this diff on origin/main due unrelated @shopify/organizations / Organization type resolution errors in app and store builds.

Post-release steps

None.

Checklist

  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've considered possible documentation changes
  • I've considered analytics changes to measure impact
  • The change is user-facing — I've identified the correct bump type (patch for bug fixes · minor for new features · major for breaking changes) and added a changeset with pnpm changeset add

Not user-facing; no changeset added.

@alfonso-noriega alfonso-noriega requested a review from a team as a code owner July 13, 2026 10:47
@github-actions github-actions Bot added the no-changelog This PR doesn't include a changeset entry. Is an internal only change not relevant to end users. label Jul 13, 2026
@alfonso-noriega alfonso-noriega force-pushed the maintenance/hot-reload-valid-scopes branch from c9a82ee to 4354814 Compare July 13, 2026 11:07
@alfonso-noriega alfonso-noriega added this pull request to the merge queue Jul 13, 2026
Merged via the queue into main with commit aa5cc21 Jul 13, 2026
28 of 29 checks passed
@alfonso-noriega alfonso-noriega deleted the maintenance/hot-reload-valid-scopes branch July 13, 2026 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-changelog This PR doesn't include a changeset entry. Is an internal only change not relevant to end users.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants