Error before app config link prompts in non-TTY#7687
Conversation
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
eebbb8e to
733fe27
Compare
e4069c5 to
c5d2d3f
Compare
3487ec3 to
a8e4e4a
Compare
a8e4e4a to
b24beaf
Compare
c5d2d3f to
2b45cf7
Compare
b24beaf to
8df1e6c
Compare
3fcd3c1 to
e4ccca0
Compare
8df1e6c to
954ecef
Compare
|
/snapit |
1 similar comment
|
/snapit |
19d3710 to
fbfc2d3
Compare
e4ccca0 to
469f7c2
Compare
|
/snapit |
|
🫰✨ Thanks @gonzaloriestra! Your snapshot has been published to npm. Test the snapshot by installing your package globally: pnpm i -g --@shopify:registry=https://registry.npmjs.org @shopify/cli@0.0.0-snapshot-20260616085935Caution After installing, validate the version by running |
fbfc2d3 to
c2d923e
Compare
469f7c2 to
1e5307e
Compare
|
/snapit |
1e5307e to
5a86eaf
Compare
c2d923e to
0fa5c90
Compare
c12f23e to
e64d42b
Compare
167ff71 to
a878d9f
Compare
e64d42b to
86de035
Compare
a878d9f to
37116bd
Compare
86de035 to
21035e3
Compare
6c7775b to
d840f99
Compare
01818eb to
da1b9b5
Compare
21264f3 to
0141b85
Compare
d69a6a6 to
98207d9
Compare
Differences in type declarationsWe detected differences in the type declarations generated by Typescript for this branch compared to the baseline ('main' branch). Please, review them to ensure they are backward-compatible. Here are some important things to keep in mind:
New type declarationsWe found no new type declarations in this PR Existing type declarationspackages/cli-kit/dist/private/node/constants.d.ts@@ -6,6 +6,7 @@ export declare const environmentVariables: {
doctor: string;
enableCliRedirect: string;
env: string;
+ firstPartyDev: string;
noAnalytics: string;
optOutInstrumentation: string;
appAutomationToken: string;
packages/cli-kit/dist/public/common/object.d.ts@@ -38,14 +38,6 @@ export declare function mapValues<T extends object, TResult>(source: T | null |
* @returns True if the objects are equal, false otherwise.
*/
export declare function deepCompare(one: object, two: object): boolean;
-/**
- * Deeply compares two values and treats arrays as order-insensitive.
- *
- * @param one - The first value to be compared.
- * @param two - The second value to be compared.
- * @returns True if the normalized values are equal, false otherwise.
- */
-export declare function deepCompareWithOrderInsensitiveArrays(one: unknown, two: unknown): boolean;
/**
* Return the difference between two nested objects.
*
packages/cli-kit/dist/public/node/context/local.d.ts@@ -63,6 +63,13 @@ export declare function alwaysLogAnalytics(env?: NodeJS.ProcessEnv): boolean;
* @returns True if SHOPIFY_CLI_ALWAYS_LOG_METRICS is truthy.
*/
export declare function alwaysLogMetrics(env?: NodeJS.ProcessEnv): boolean;
+/**
+ * Returns true if the CLI User is 1P.
+ *
+ * @param env - The environment variables from the environment of the current process.
+ * @returns True if SHOPIFY_CLI_1P is truthy.
+ */
+export declare function firstPartyDev(env?: NodeJS.ProcessEnv): boolean;
/**
* Returns true if the CLI can run the "doctor-release" command.
*
|
98207d9 to
8bbb221
Compare
8bbb221 to
1a3ddeb
Compare
0a8a2d3 to
42c3570
Compare
1a3ddeb to
adbdf99
Compare
42c3570 to
8d0d5a2
Compare
adbdf99 to
8cc0e88
Compare
8d0d5a2 to
4f7a225
Compare
|
/snapit |
1 similar comment
|
/snapit |
8cc0e88 to
874968a
Compare
4f7a225 to
6de9f11
Compare
|
/snapit |
|
🫰✨ Thanks @gonzaloriestra! Your snapshot has been published to npm. Test the snapshot by installing your package globally: pnpm i -g --@shopify:registry=https://registry.npmjs.org @shopify/cli@0.0.0-snapshot-20260714080904Caution After installing, validate the version by running |

WHY are these changes introduced?
Related to https://github.com/shop/issues-develop/issues/22869
app config linkcan still reach prompt-only paths when a caller has not provided enough information to choose the remote app or local config file name. In non-interactive environments, that should fail with actionable guidance instead of attempting to render prompts.This is especially important for commands that call linking indirectly: they should surface that the project needs to be linked first with explicit flags, rather than hanging or failing inside prompt rendering.
WHAT is this pull request doing?
app config linkprompts for remote app selection.app config linkprompts for a new config file name.shopify app config linkwith the missing required flags, such as--client-idor--file-name.How to test your changes?
CI=1 shopify app config linkCI=1 shopify app config link --client-id new-appChecklist
pnpm changeset add