Allow app config validate to target config by client ID#7631
Allow app config validate to target config by client ID#7631gonzaloriestra wants to merge 1 commit into
Conversation
This stack of pull requests is managed by Graphite. Learn more about stacking. |
51b7815 to
63fab66
Compare
22f6bf8 to
1dcfefd
Compare
4bd2cf5 to
986b2a7
Compare
986b2a7 to
872015f
Compare
1dcfefd to
7bc268b
Compare
872015f to
81fed1d
Compare
7bc268b to
2247c50
Compare
81fed1d to
950e211
Compare
2247c50 to
87644b5
Compare
8cfe2a7 to
e2500b0
Compare
87644b5 to
772ca83
Compare
e2500b0 to
3913769
Compare
772ca83 to
4fc790f
Compare
2f2fa6d to
d3c61c4
Compare
7032f1f to
fed0194
Compare
d3c61c4 to
2dd690e
Compare
2dd690e to
847afd2
Compare
fed0194 to
7cb3d48
Compare
847afd2 to
f25a459
Compare
7cb3d48 to
72d1300
Compare
|
When using |
72d1300 to
fd60151
Compare
f25a459 to
1ad8032
Compare
Differences in type declarationsWe detected differences in the type declarations generated by Typescript for this branch compared to the baseline ('main' branch). Please, review them to ensure they are backward-compatible. Here are some important things to keep in mind:
New type declarationsWe found no new type declarations in this PR Existing type declarationspackages/cli-kit/dist/private/node/session.d.ts@@ -90,7 +90,6 @@ export declare function setLastSeenUserIdAfterAuth(id: string): void;
*/
export declare function getLastSeenAuthMethod(): Promise<AuthMethod>;
export declare function setLastSeenAuthMethod(method: AuthMethod): void;
-export declare function setCommandSessionId(sessionId: string | undefined): void;
export interface EnsureAuthenticatedAdditionalOptions {
noPrompt?: boolean;
forceRefresh?: boolean;
packages/cli-kit/dist/public/node/base-command.d.ts@@ -16,7 +16,6 @@ declare abstract class BaseCommand extends Command {
protected parse<TFlags extends FlagOutput & {
path?: string;
verbose?: boolean;
- 'auth-alias'?: string;
}, TGlobalFlags extends FlagOutput, TArgs extends ArgOutput>(options?: Input<TFlags, TGlobalFlags, TArgs>, argv?: string[]): Promise<ParserOutput<TFlags, TGlobalFlags, TArgs> & {
argv: string[];
}>;
packages/cli-kit/dist/public/node/cli.d.ts@@ -39,9 +39,6 @@ export declare const globalFlags: {
export declare const jsonFlag: {
json: import("@oclif/core/interfaces").BooleanFlag<boolean>;
};
-export declare const authAliasFlag: {
- 'auth-alias': import("@oclif/core/interfaces").OptionFlag<string | undefined, import("@oclif/core/interfaces").CustomOptions>;
-};
/**
* Builds a flag that only accepts a valid port number. The flag parses its
* value as an integer and rejects anything that isn't a whole number between 1 and
packages/cli-kit/dist/public/node/session.d.ts@@ -22,19 +22,6 @@ export type AccountInfo = UserAccountInfo | ServiceAccountInfo | UnknownAccountI
* @param userId - User identifier to report on the command analytics event.
*/
export declare function setLastSeenUserId(userId: string): void;
-/**
- * Finds a stored Shopify account session by alias without changing the current session.
- *
- * @param alias - The account alias to find.
- * @returns The matching session ID, or undefined if no session matches.
- */
-export declare function findSessionIdByAlias(alias: string): Promise<string | undefined>;
-/**
- * Selects a stored Shopify account session by alias for the current command process.
- *
- * @param alias - The account alias to select. Passing undefined clears the command selection.
- */
-export declare function setCurrentSessionAlias(alias?: string): Promise<void>;
interface UserAccountInfo {
type: 'UserAccount';
email: string;
|
fd60151 to
9bafc2f
Compare
1ad8032 to
6d26b55
Compare
6d26b55 to
86468f6
Compare
86468f6 to
fdb6f29
Compare
|
@isaacroldan it works for me, how did you try? I'm trying with |
|
um, the issue is that I was making changes in the toml that I think prevented parsing it and then it defaulted to the cached one 🤔 Which I think is... correct? or not? is confusing |

WHY are these changes introduced?
The interactivity audit found that
shopify app config validate --client-id <id>can still prompt while resolving the active local config, especially when the cached config points at a file that no longer exists.WHAT is this pull request doing?
--client-idis provided.--client-idis not provided.How to test your changes?
Remove the current config and pass a client from another one. It should validate without asking for the config.
shopify app config validate --client-idChecklist
pnpm changeset add