Repository navigation
Raise the default CHK chunks per tag limit to the total chunk limit - #8
Open
2Pacalypse- wants to merge 1 commit into
Open
2Pacalypse- wants to merge 1 commit into
2Pacalypse- wants to merge 1 commit into
Conversation
Tribe Control 1.4, a released map, pads its CHK with 16,396 mostly empty chunks under an all-zero tag and was rejected one chunk over the 16 Ki default. Every retained chunk already counts toward max_chk_chunks, so matching that limit keeps memory bounded the same way.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ShieldBattery's full prod map scan found one released map, Tribe Control 1.4 (256x256 UMS), that the default limits reject: its CHK pads 16,396 chunks (1 KB in total) under an all-zero tag, one over the 16 Ki per-tag default (
observed: 16385, limit: 16384). The old bw-chk parser accepted it.Every retained chunk already counts toward
max_chk_chunks(64 Ki), so raising the per-tag default to match keeps memory bounded the same way. Unknown-tag chunks stay retained becauseChk::chunks()exposes them.Checked: the map parses with the change and fails without it; a unit test covers 16,396 empty chunks of one tag under the defaults.
cargo test, clippy and fmt pass.