Repository navigation
Raise the default file, CHK and merged chunk size limits to 256 MiB. - #10
Open
2Pacalypse- wants to merge 1 commit into
Open
2Pacalypse- wants to merge 1 commit into
2Pacalypse- wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Real maps have CHKs well over the old 64 MiB defaults. 랜능크 하제 v2.1.3 is a 5 MB
.scxwhosescenario.chkis 127,455,624 bytes, and the game plays it fine. With default limits it fails:ShieldBattery already overrides these three limits to 256 MiB everywhere it parses maps. Raising the defaults means callers no longer have to remember to: one ShieldBattery call site that didn't pass overrides failed to render this map. Decompression bombs are still bounded by the 500:1 sector ratio and the sector/table/chunk count limits; only the absolute size caps move.
broodmap-cli minimaprenders the map with the new defaults;cargo test -p broodmapand clippy pass.This touches the line next to #8's
max_chk_chunks_per_tagchange, so whichever merges second needs a trivial rebase.