Skip to content

Housekeeping: drop the stale cache, fail on deprecations #54

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
loevgaard merged 1 commit into from
Sep 14, 2026
Merged

Housekeeping: drop the stale cache, fail on deprecations #54

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
/vendor/
/composer.lock
/.phpunit.result.cache
/.build/
15 changes: 13 additions & 2 deletions phpunit.xml.dist
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,8 @@
<?xml version="1.0" encoding="UTF-8"?>
<phpunit xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
xsi:noNamespaceSchemaLocation="vendor/phpunit/phpunit/phpunit.xsd" bootstrap="vendor/autoload.php"
colors="true" cacheDirectory=".build/phpunit">
colors="true" cacheDirectory=".build/phpunit"
failOnDeprecation="true" failOnNotice="true" failOnWarning="true">
<testsuites>
<testsuite name="unit">
<directory>tests/Unit</directory>
Expand All @@ -10,7 +11,17 @@
<directory>tests/Integration</directory>
</testsuite>
</testsuites>
<source>

<!--
restrictDeprecations keeps the report to deprecations this bundle's own code triggers, so an upstream one
does not drown ours out and failOnDeprecation can stay on. setono/bot-detection-bundle currently has
implicitly nullable parameters, which PHP 8.4 deprecates and PHP 9 will reject.

Do NOT let PHPUnit migrate this file: the migration renames the attribute to ignoreIndirectDeprecations,
which PHPUnit 10.5 rejects. We still need 10.5, because PHPUnit 11 requires PHP 8.2 and this bundle
supports 8.1
-->
<source restrictNotices="true" restrictWarnings="true" restrictDeprecations="true">
<include>
<directory suffix=".php">src/</directory>
</include>
Expand Down
Loading