Housekeeping: ignore .idea, drop the stale cache, fail on deprecations - #54
Open
loevgaard wants to merge 1 commit into
Open
Housekeeping: ignore .idea, drop the stale cache, fail on deprecations#54loevgaard wants to merge 1 commit into
loevgaard wants to merge 1 commit into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## fix/30-bundle-structure #54 +/- ##
==========================================================
Coverage 81.97% 81.97%
Complexity 171 171
==========================================================
Files 35 35
Lines 538 538
==========================================================
Hits 441 441
Misses 97 97 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
loevgaard
force-pushed
the
fix/30-bundle-structure
branch
from
September 7, 2026 12:03
c17b1a2 to
df6dd77
Compare
loevgaard
force-pushed
the
fix/33-housekeeping
branch
from
September 7, 2026 12:03
0c0cd69 to
3b2efc9
Compare
loevgaard
force-pushed
the
fix/30-bundle-structure
branch
from
September 7, 2026 12:18
df6dd77 to
00aed2f
Compare
loevgaard
force-pushed
the
fix/33-housekeeping
branch
from
September 7, 2026 12:18
3b2efc9 to
f15ba02
Compare
loevgaard
force-pushed
the
fix/30-bundle-structure
branch
from
September 7, 2026 12:47
00aed2f to
964b4b5
Compare
loevgaard
force-pushed
the
fix/33-housekeeping
branch
from
September 7, 2026 12:47
f15ba02 to
a25a734
Compare
loevgaard
force-pushed
the
fix/30-bundle-structure
branch
from
September 7, 2026 12:51
964b4b5 to
6064e42
Compare
loevgaard
force-pushed
the
fix/33-housekeeping
branch
from
September 7, 2026 12:51
a25a734 to
19e4dc4
Compare
Ignore the IDE directory, remove the stale .phpunit.result.cache left at the root from before cacheDirectory was configured, and turn on failOnDeprecation with ignoreIndirectDeprecations so this bundle's own deprecations surface without the upstream ones from setono/bot-detection-bundle masking them. Fixes #33
loevgaard
force-pushed
the
fix/30-bundle-structure
branch
from
September 7, 2026 12:57
6064e42 to
064cf2d
Compare
loevgaard
force-pushed
the
fix/33-housekeeping
branch
from
September 7, 2026 12:57
19e4dc4 to
05661e3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #33
Changes
.gitignore./.idea/was untracked only because nobody had added it yet. Added, along with/.vscode/. Dropped the/.phpunit.result.cacheentry, since that file no longer belongs at the root.Stale cache.
phpunit.xml.distsetscacheDirectory=".build/phpunit", but a.phpunit.result.cachefrom before that change was still sitting at the repository root. Deleted.Deprecations now fail the build. The suite reported three PHP deprecations on PHP 8.4, all from
setono/bot-detection-bundle(BotDetector::__construct()parameter$popularandBotDetectorInterface::isBotRequest()parameter$requestare implicitly nullable). Because they came from a dependency, they could not simply be fixed here, and while they were in the output a new deprecation from this bundle's own code would have gone unnoticed.<source ignoreIndirectDeprecations="true">limits reporting to deprecations triggered by code undersrc/, which makesfailOnDeprecation="true"safe to turn on, together withfailOnNoticeandfailOnWarning. The suite now reports OK (136 tests, 316 assertions) with nothing after it.The configuration was also migrated to the current PHPUnit schema, which the runner had been warning about.
Still worth doing upstream: giving those two
BotDetectorInterfaceparameters an explicit?Type, since PHP 9 turns the deprecation into an error. Once released, the constraint here can be bumped andignoreIndirectDeprecationsrevisited.Note on Codecov
The coverage job uploads to Codecov but nothing consumes the result. That is handled in the test coverage PR rather than here.