Repository navigation
Conversation
Seagulls
changed the base branch from
fix/upstream-root-topology
to
fix/pr139-bounded-wait-20261031
October 31, 2026 19:43
This was referenced Oct 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scope
Stacked draft on
fix/pr139-bounded-wait-20261031(public PR #25; revised upstream Liquid-co#139). Retains all prior #24 commits through merge parentage and includes the maintainer-requested 30-second interactive topology wait. Not an independentdev-publicPR.Issue #20 documents an independently reproduced loss of tracked coverage: when root transfer is refused, existing
LinkGamescan log the failure but proceed to delete the original game registration. This change:Proof
Synthetic local tests against a PR-139-equivalent prototype: busy canonical writer preserves alias registration (GREEN); injected SQL failure during second named-root carry rolls back earlier transfer and alias/history changes (GREEN); ordinary successful carry remains GREEN. Full
storeanddaemonpackage suites passed locally, but an exact branch-head CI/race/e2e campaign is still required. Tests added in this branch cover both paths.Integration and limitations
Draft; do not merge ahead of PR Liquid-co#139. When upstream Liquid-co#139 removes its current
LinkGamesguard in response to maintainer scope feedback, rebase this stacked branch and preserve the new two-game admission mechanism. Do not treat this as daemon cross-process ownership or SaveSync first-copy acceptance. No real save data or deployment.31 Oct 2026 CI correction and re-stack
Original branch E2E RED on Linux and Windows:
TestPeerLink_ListsPeerGamesAndLinksThemandTestMatching_LinkedGameActuallyTransfersDatareceived HTTP 500 fromLinkGameswhile normal track-triggered sync activity was still admitted (failed run). The immediateTryTopologyMutationrefusal was incompatible with normal interactive linking; it was not evidence that root data was modified.Commit
b8494cef084d1906ec626f66b1458459d0958c97reconciles PR #24 with passing PR #25, uses itsWaitTopologyMutationprimitive with one 30-second deadline and deterministic two-game reservation, and preserves the atomic link transaction. An actual busy timeout now returns HTTP 409 rather than an internal 500; cancellation or failed admission commits no alias, root or history effects. The daemon tests exercise a writer that drains and an indefinitely busy writer with a short test context.Exact-head CI run is authoritative and was pending when this note was prepared; do not mark ready for merge until it is green and the original failed E2E cases are observed passing.