Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cause
The existing
TestIndexNoWait_NoIndexYetassumes an asynchronously launched manifest index build cannot finish beforeloadManifestIndexNoWait()returns. On faster CI hosts, it legitimately finishes and returns the new catalogue, making the test fail despite correct no-wait behavior.Observed failure in PR #23 CI:
TestIndexNoWait_NoIndexYetreturnedNew Gameinstead of an empty catalogue.Minimal fix
Reuse the test suite's existing
slowBuildsgate, explicitly wait until the async rebuild has started, then release it and check that the next read sees the index. No production changes, no sleeps added to the implementation, no weakening of the no-wait contract.Validation
Source-level sequencing checked; exact-head CI pending. Keep independent of save-path CAS PR #23 and topology/linking PR #24.