[Feat] Persist typed decision rules for custom automations - #3090
Closed
roomote-roomote[bot] wants to merge 2 commits into
Closed
roomote-roomote[bot] wants to merge 2 commits into
roomote-roomote[bot] wants to merge 2 commits into
Conversation
Contributor
roomote-roomote
Bot
requested review from
brunobergher,
daniel-lxs and
mrubens
as code owners
September 22, 2026 06:21
Contributor
Author
|
Closing for now per @daniel-lxs. The direction is moving to declarative |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
goalfrom the saved prompt andresultfrom a future completed outcome), one TypeSafechoicequestion, three allowed outcomes (addressed,needs_review,no_match), and a code-ownedpreserve_deliveryconsequence for every outcome.Why this change was made
The prototype now tests the structured decision-rule contract itself instead of introducing shadow execution or per-run timing. The saved rule is replaced on create/edit and is not consumed by a run in this slice, so there is no stale-spec race or model-controlled delivery path.
Impact
Authorized automation owners and admins can inspect the exact typed rule that would constrain a future judgment-model call. The model has no path to authorize, suppress, rewrite, retry, or reroute automation work. Focused rule/persistence/API/UI tests, package type checks,
pnpm lint:fast, andpnpm check-types:fastpassed;pnpm knipcompleted with the repository's existingapps/docs/mintconfiguration hint. The screenshot uses a temporary local automation row for presentation only; it was deleted after capture.Screenshots