[Feat] Add opt-in launch criteria to custom automations - #3159
Merged
daniel-lxs merged 12 commits intoSep 25, 2026
Merged
Conversation
Contributor
|
No new code issues found. See task
Reviewed 6678563 |
roomote-roomote
Bot
requested review from
brunobergher,
daniel-lxs and
mrubens
as code owners
September 23, 2026 06:42
…omation-run-conditions-1ic82um4i96le
…omation-run-conditions-1ic82um4i96le
Contributor
Author
|
Fixed both outstanding findings in 7345263f: queued Discord/Teams runs now restore deferred roots when the experiment is disabled, and row-level automation toggles omit saved launch criteria while disabled so the update succeeds without clearing the saved rule. The Roomote code review check reran on the pushed head and passed; the latest review summary reports no code issues, and both requested review threads are resolved. Focused web and Fast regression tests, affected typechecks, lint, and pre-push checks passed. The browser-proof capture for this follow-up timed out, so the PR body has no stale screenshots. See the task for the details. |
…omation-run-conditions-1ic82um4i96le
6 of 8 tasks
…omation-run-conditions-1ic82um4i96le
daniel-lxs
approved these changes
Sep 25, 2026
…omation-run-conditions-1ic82um4i96le
daniel-lxs
deleted the
feature/custom-automation-run-conditions-1ic82um4i96le
branch
September 25, 2026 03:29
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
runWhenconditions to custom automations in Settings, the REST API, andmanage_custom_automations.0117_black_titania.sql; develop uses0116_overrated_romulus.sqlfor task-run completion/cancellation indexes.Why this change was made
Launch criteria change whether scheduled work begins, so their control and runtime behavior should be available only on deployments explicitly enabled for internal nightly experiments. Saved conditions and queued destination replies must remain safe when the experiment is off.
Impact
8af03c33c7f86b8755fb16a131d8125ec637b1a1confirmed the Nightly route is unavailable and criteria writes are rejected when the deployment opt-in is off. With the environment opt-in on but the experiment off, saved criteria survived four row toggles and a schedule update, and runtime ignored them. With the experiment on, real Jev returned a confident skip at0.04(saved privately and hidden from Results), a pass at0.80(continued to a shared result), and uncertain results at0.65/0.66(continued).listResultsCommandshowed the shared control and excluded both private rows. For execution provenance, the result writer, shared enqueue, and Results query ran from a clean worktree at the PR head; the already-running background scheduler/worker performed recovery. Its queue and processor source is unchanged between that runtime revision and the PR head, so this does not claim the entire service stack ran at the PR head. All temporary rows, the disposable automation, queue jobs, and the three associated usage records were removed.Screenshots