Skip to content

fix(react): prevent intra-word _ and * from rendering as emphasis #1375

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rahulnits-sketch wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

fix(react): prevent intra-word _ and * from rendering as emphasis #1375

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 24 additions & 1 deletion packages/react/src/lib/contentEditableComposer.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,26 @@ const findLink = (text, start) => {
};
};

const isAlphanumeric = (ch) => Boolean(ch && /[a-zA-Z0-9]/.test(ch));
const isWhitespace = (ch) => Boolean(ch && /\s/.test(ch));

const isValidEmphasis = (marker, text, start, end) => {
if (marker === '`' || marker === '~~') {
return true;
}
const prevChar = start > 0 ? text[start - 1] : '';
const firstInside = text[start + marker.length];
const lastInside = text[end - 1];
const nextChar =
end + marker.length < text.length ? text[end + marker.length] : '';

if (isWhitespace(firstInside) || isWhitespace(lastInside)) return false;
if (isAlphanumeric(prevChar)) return false;
if (isAlphanumeric(nextChar)) return false;

return true;
};

const appendMarkdown = (parent, text) => {
const tokens = [
['**', 'strong'],
Expand Down Expand Up @@ -92,7 +112,10 @@ const appendMarkdown = (parent, text) => {
if (token) {
const [marker, tagName] = token;
const end = text.indexOf(marker, index + marker.length);
if (end > index + marker.length) {
if (
end > index + marker.length &&
isValidEmphasis(marker, text, index, end)
) {
flush();
const formatted = document.createElement(tagName);
const content = text.slice(index + marker.length, end);
Expand Down