fix(react): prevent intra-word _ and * from rendering as emphasis - #1375
Open
rahulnits-sketch wants to merge 1 commit into
Open
rahulnits-sketch wants to merge 1 commit into
rahulnits-sketch wants to merge 1 commit into
Conversation
rahulnits-sketch
force-pushed
the
fix/intra-word-emphasis
branch
from
September 25, 2026 16:15
0151fef to
bd8a429
Compare
Author
|
Hi @Spiral-Memory, I have updated the commit author to align with my signed CLA, so all checks (including the CLA assistant) are now passing green ✅. The changes in |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brief Title
fix(react): prevent intra-word
_and*from rendering as emphasis in composerAcceptance Criteria fulfillment
_and*delimiters from being parsed as italics or bold (e.g.my_file_name.js,foo_bar_baz)2 * 3 * 4) do not trigger emphasis_italic_,**bold**,(_italic_))yarn buildFixes #1372
PR Test Details
Note: The PR will be ready for live testing at https://rocketchat.github.io/EmbeddedChat/pulls/pr-1375 after approval.
Test Matrix
my_file_name.jsmy<em>file</em>name.jsmy_file_name.jscall foo_bar_baz() nowcall foo<em>bar</em>baz() nowcall foo_bar_baz() now2 * 3 * 4 = 242 <em> 3 </em> 4 = 242 * 3 * 4 = 24This is _italic_ textThis is <em>italic</em> textThis is <em>italic</em> textThis is **bold** textThis is <strong>bold</strong> textThis is <strong>bold</strong> text(_italic_)(<em>italic</em>)(<em>italic</em>)