Repository navigation
Add optional window-local path diagnostics to historical net reports - #592
Merged
Merged
Conversation
1 of 7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The historical Batch A CLI can now explicitly add window-local path diagnostics from the same validated net-return ledger that supplies each existing report. The optional flag works independently of the existing twelve-metric report, preserves zero-return observations, and refuses unavailable capabilities before reading private inputs. Default reports, fees, paths, rankings, qualification gates, and production dependency pins are preserved.
The four measurements count return observations, including explicit terminal censoring and unknown history before the selected window. They do not establish calendar durations, closed-trade outcomes, research qualification, account balances, or order authority. The existing isolated report-acceptance job binds the already merged immutable QPK source and requires both old and new positive CLI/hand-math cases with no skips.
Validation: final 48 focused cases passed with zero skips; CONTRIBUTING unittest 246 passed; full local pytest against the isolated latest source overlay passed 2,506 cases with 3 existing skips and 460 subtests; Ruff, dependency check and all-workflow actionlint with ShellCheck passed. Root and independent review verified the six-file scope, all 420 unowned tracked files, and the complete original test prefix unchanged. Final PR CI also exercises the unchanged production dependency pins; all final checks and post-merge main CI will be recorded in #588 and QuantRuntimeSettings #632. No private research workflow, new strategy trial, deployment, or trading action is invoked.