Repository navigation
fix(console): label weekend run-status gaps as non-trading days - #993
Merged
Merged
Conversation
On Saturdays and Sundays the run-status page showed 0/N accounts with today's records and "no data" rows, which read like a data outage. There is no market-holiday source in the Worker, so only weekends are provable. Classify the business day as weekend/trading_day, tag missing records on weekends as non_trading_weekend for non-crypto platforms, and show a localized note on the health page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/api/runtime/todaynow reportsmarket_session: weekend|trading_day(weekends are the only provable closure without a holiday source).non_trading_weekendinstead oftoday_record_missing.Test plan
node --test tests/fe8a_runtime_today_validation.mjs(incl. new weekend case)node tests/runtime_today_request_reuse_validation.mjsnode tests/console_design_api_validation.mjsnode tests/console_v2_i18n_validation.mjsnode --test tests/fe8b_fix03_ui_validation.mjsnpx tsc --noEmit