Skip to content

fix(console): align live defaults and name unsupported fields - #1026

Merged
Pigbibi merged 1 commit into
mainfrom
fix/console-wrangler-align-live
Nov 1, 2026
Merged

Pigbibi merged 1 commit into
mainfrom
fix/console-wrangler-align-live

Conversation

@Pigbibi

@Pigbibi Pigbibi commented Nov 1, 2026

Copy link
Copy Markdown
Contributor

AI assistance

OpenAI Codex using the model configured by the host for this session. No sub-agents.

What changed

The render-and-compare run 41300868421 on main a38c939c reported five blockers. This change addresses four equality blockers and makes the remaining unsupported field identifiable, while keeping it fail closed.

Original blocker Change and read-only evidence
runtime.compatibility_flags / missing_runtime_setting The template has no nonempty flags; live settings returned an empty list and the active runtime omitted the field. Missing/null/empty API flags now match only an omitted/empty rendered list. Nonempty flags still require an exact match, and invalid shapes or missing required dates still block.
settings.placement / undeclared_effective_setting Live placement is {}. Declare placement = { mode = "off" }. Verified Wrangler 4.106.0 omits placement for exactly this configuration; compare it with the absent/empty no-placement state. Other placement differences remain blocking.
settings.tags / undeclared_effective_setting Live tags are []. Wrangler 4.106.0 does not support top-level tags; adding that setting would be ignored. Keep tags omitted and accept only the verified empty-list preservation for this template without environment grouping. Nonempty live-only tags remain unreadable; fictitious top-level tag declarations also fail closed.
settings.observability / mismatch Live observability is absent. Keep it omitted in the template; absent/absent now matches. An omitted config also matches exactly disabled live observability, consistent with Wrangler's documented no-op disable. No logging is enabled.
settings.unsupported[0] / unsupported_live_setting A fresh GET-only read identified the field name as annotations. Add a sanitized field detail, limited to [A-Za-z0-9_.-]{1,64}, with a fixed placeholder otherwise. The reason and unreadable status are retained. Values and nested content are never emitted.

The same name-only diagnostic covers unsupported config, runtime and subdomain keys. Tests cover empty-value equivalence, real differences, invalid shapes, undeclared settings, regex boundaries and secret-value redaction. Update the existing comparison documentation.

The effective placement, tags, flags and logging behavior are unchanged. Read-only observations were stable; all raw API responses, credentials and account IDs remained in process memory, and only selected non-sensitive metadata was saved outside Git. No item required guessing or an unreadable-value workaround.

Remaining boundary: annotations is still unsupported. This PR does not establish all_match=true, approve a deployment, or make PR #1014 deployable by itself. Its handling must be reviewed before a separately authorized post-merge comparison can pass. No unsupported field was allowlisted or ignored to force a match.

How verified

  • Full Python suite on Python 3.12: 1,057 tests, OK (skipped=10). The existing skips require an actual local AIAuditBridge producer artifact; no such artifact was fabricated.
  • Focused comparator suite: all 28 tests passed. The original comparator fails the new empty-flags, observed-config and named-diagnostic regressions.
  • Full CI Node/TypeScript validation block on Node 22: passed, including all 118 Node/TypeScript commands, frontend build/asset checks, operations tests and the conditional historical synthetic bundle/AST/Worker tests. Offline evidence builds used wrangler deploy --dry-run only; temporary source was retained instead of running the build scripts' deletion traps.
  • Wrangler 4.106.0 parsed the final template without warnings: placement off, empty flags, no tags/observability declaration, no environment grouping. Source inspection verified parseConfigPlacement, preUploadApiChecks, applyServiceAndEnvironmentTags and the implicit observability disable.
  • Generated display names/config checks, runtime target validation, pip check, Python package build, documentation checker tests (36), documentation rules, Actionlint and git diff --check: passed. The existing root README advisory is unrelated and the documentation checker exited 0.
  • Redacted Gitleaks scan of the complete patch: passed.
  • A separately marked offline projection of the observed live shapes produces four matches and one unreadable annotations diagnostic. This is not a new full production comparison or a deployment result.
  • GitHub CI will be recorded in the task report after it completes; any owner-approval gate remains untouched.

Source: fresh HTTPS clone under ~/codex-jobs/qrs-console-align/, based on origin/main a38c939c. The Projects clone was never accessed. Only this feature branch is pushed. No merge, label, deployment, Cloudflare write, IAM/GCS change, trading action, or deploy workflow dispatch is part of this PR. Any owner-approval governance requirement is left intact and no label is applied.

Co-Authored-By: Codex <noreply@openai.com>
@coderabbitai

coderabbitai Bot commented Nov 1, 2026

Copy link
Copy Markdown

Important

  • Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 9521f7d8-9643-4cc3-abac-1fce5cb8dd44
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@Pigbibi Pigbibi added the owner-approved Owner approval for high-risk PRs. AI agents must never apply this label. label Nov 1, 2026 — with Cursor
@Pigbibi
Pigbibi merged commit e0437ad into main Nov 1, 2026
16 of 17 checks passed
@Pigbibi
Pigbibi deleted the fix/console-wrangler-align-live branch November 1, 2026 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

owner-approved Owner approval for high-risk PRs. AI agents must never apply this label.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant