Repository navigation
fix(console): align live defaults and name unsupported fields - #1026
Merged
Merged
Conversation
Co-Authored-By: Codex <noreply@openai.com>
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AI assistance
OpenAI Codex using the model configured by the host for this session. No sub-agents.
What changed
The render-and-compare run 41300868421 on main
a38c939creported five blockers. This change addresses four equality blockers and makes the remaining unsupported field identifiable, while keeping it fail closed.runtime.compatibility_flags/missing_runtime_settingsettings.placement/undeclared_effective_setting{}. Declareplacement = { mode = "off" }. Verified Wrangler 4.106.0 omits placement for exactly this configuration; compare it with the absent/empty no-placement state. Other placement differences remain blocking.settings.tags/undeclared_effective_setting[]. Wrangler 4.106.0 does not support top-leveltags; adding that setting would be ignored. Keep tags omitted and accept only the verified empty-list preservation for this template without environment grouping. Nonempty live-only tags remain unreadable; fictitious top-level tag declarations also fail closed.settings.observability/ mismatchsettings.unsupported[0]/unsupported_live_settingannotations. Add a sanitizedfielddetail, limited to[A-Za-z0-9_.-]{1,64}, with a fixed placeholder otherwise. The reason and unreadable status are retained. Values and nested content are never emitted.The same name-only diagnostic covers unsupported config, runtime and subdomain keys. Tests cover empty-value equivalence, real differences, invalid shapes, undeclared settings, regex boundaries and secret-value redaction. Update the existing comparison documentation.
The effective placement, tags, flags and logging behavior are unchanged. Read-only observations were stable; all raw API responses, credentials and account IDs remained in process memory, and only selected non-sensitive metadata was saved outside Git. No item required guessing or an unreadable-value workaround.
Remaining boundary:
annotationsis still unsupported. This PR does not establishall_match=true, approve a deployment, or make PR #1014 deployable by itself. Its handling must be reviewed before a separately authorized post-merge comparison can pass. No unsupported field was allowlisted or ignored to force a match.How verified
OK (skipped=10). The existing skips require an actual local AIAuditBridge producer artifact; no such artifact was fabricated.wrangler deploy --dry-runonly; temporary source was retained instead of running the build scripts' deletion traps.parseConfigPlacement,preUploadApiChecks,applyServiceAndEnvironmentTagsand the implicit observability disable.pip check, Python package build, documentation checker tests (36), documentation rules, Actionlint andgit diff --check: passed. The existing root README advisory is unrelated and the documentation checker exited 0.annotationsdiagnostic. This is not a new full production comparison or a deployment result.Source: fresh HTTPS clone under
~/codex-jobs/qrs-console-align/, based on origin/maina38c939c. The Projects clone was never accessed. Only this feature branch is pushed. No merge, label, deployment, Cloudflare write, IAM/GCS change, trading action, or deploy workflow dispatch is part of this PR. Any owner-approval governance requirement is left intact and no label is applied.