Repository navigation
fix(console): classify Worker annotations without hiding drift - #1028
Merged
Merged
Conversation
Co-Authored-By: Codex <noreply@openai.com>
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AI assistance
OpenAI Codex (GPT-6). No delegated agents were used.
What changed
The live Worker settings response includes
annotations, which the Consoleconfig comparator previously reported as an unsupported setting. Recognize the
documented version metadata keys
workers/message,workers/tag, andworkers/triggered_by, record value-redacted rows withclassification=deployment_metadata, and exclude valid, non-runtime metadatafrom config drift. This branch starts from main after #1026 was merged.
Keep unknown keys (including version URL aliases), malformed shapes, non-string
values, invalid Unicode, and oversized message/tag values unreadable. Unknown
annotation key names are also redacted. A version tag remains unreadable if
either binding inventory is incomplete/malformed or exposes a
version_metadatabinding, since Worker code can consume that tag. Local annotations declarations
and runtime annotations remain unsupported. Full-snapshot stability checks and
GET-only access remain in place.
The policy follows Cloudflare's settings API,
upload annotations,
and version metadata binding
documentation. Update the existing Console README with these comparison rules.
How verified
metadata classification, unknown keys, malformed/oversized values, UTF-8,
runtime tag exposure, redacted CLI output, nonzero failure exit, and observation
stability. Reproduced the unsupported-annotations behavior before the patch.
OK (skipped=10); the existing skips requireactual local producer artifacts.
pip check,Python package build, 36 documentation-checker tests, phase-2 documentation
rules, diff whitespace, and redacted Gitleaks scans passed. Documentation has
one existing root README advisory and zero blocking findings.
harness was corrected. An existing 30ms deadline test also expired early on
that run; its 20-test module and the final complete suite passed without
changing the existing test or timeout.
for this Python-only behavior change.
The live read stopped before its first Cloudflare request because the existing
local Wrangler credential had expired (
expired_local_auth). No credential wasrefreshed, and no remote values were printed or saved. The annotation policy is
verified against current official documentation and synthetic regression tests;
this PR does not claim that the complete live comparison passes.
No labels, merge, deployment, configuration writes, or workflow dispatches are
part of this change.