Skip to content

fix(console): classify Worker annotations without hiding drift - #1028

Merged
Pigbibi merged 1 commit into
mainfrom
fix/console-annotations-metadata
Nov 1, 2026
Merged

Pigbibi merged 1 commit into
mainfrom
fix/console-annotations-metadata

Conversation

@Pigbibi

@Pigbibi Pigbibi commented Nov 1, 2026

Copy link
Copy Markdown
Contributor

AI assistance

OpenAI Codex (GPT-6). No delegated agents were used.

What changed

The live Worker settings response includes annotations, which the Console
config comparator previously reported as an unsupported setting. Recognize the
documented version metadata keys workers/message, workers/tag, and
workers/triggered_by, record value-redacted rows with
classification=deployment_metadata, and exclude valid, non-runtime metadata
from config drift. This branch starts from main after #1026 was merged.

Keep unknown keys (including version URL aliases), malformed shapes, non-string
values, invalid Unicode, and oversized message/tag values unreadable. Unknown
annotation key names are also redacted. A version tag remains unreadable if
either binding inventory is incomplete/malformed or exposes a version_metadata
binding, since Worker code can consume that tag. Local annotations declarations
and runtime annotations remain unsupported. Full-snapshot stability checks and
GET-only access remain in place.

The policy follows Cloudflare's settings API,
upload annotations,
and version metadata binding
documentation. Update the existing Console README with these comparison rules.

How verified

  • Comparator regression suite: 37 tests passed, including 9 new tests for
    metadata classification, unknown keys, malformed/oversized values, UTF-8,
    runtime tag exposure, redacted CLI output, nonzero failure exit, and observation
    stability. Reproduced the unsupported-annotations behavior before the patch.
  • Full Python suite: 1,066 tests, OK (skipped=10); the existing skips require
    actual local producer artifacts.
  • Generated display names and platform config, runtime targets, pip check,
    Python package build, 36 documentation-checker tests, phase-2 documentation
    rules, diff whitespace, and redacted Gitleaks scans passed. Documentation has
    one existing root README advisory and zero blocking findings.
  • The first full run exposed a missing file-read mock in the new CLI test; that
    harness was corrected. An existing 30ms deadline test also expired early on
    that run; its 20-test module and the final complete suite passed without
    changing the existing test or timeout.
  • Remote CI results will be reported separately; no local Node build was needed
    for this Python-only behavior change.

The live read stopped before its first Cloudflare request because the existing
local Wrangler credential had expired (expired_local_auth). No credential was
refreshed, and no remote values were printed or saved. The annotation policy is
verified against current official documentation and synthetic regression tests;
this PR does not claim that the complete live comparison passes.

No labels, merge, deployment, configuration writes, or workflow dispatches are
part of this change.

Co-Authored-By: Codex <noreply@openai.com>
@coderabbitai

coderabbitai Bot commented Nov 1, 2026

Copy link
Copy Markdown

Important

  • Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: fc1e8e99-918a-4bd3-b7fb-42401a0bbcb1
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@Pigbibi Pigbibi added the owner-approved Owner approval for high-risk PRs. AI agents must never apply this label. label Nov 1, 2026 — with Cursor
@Pigbibi
Pigbibi merged commit 3b27e60 into main Nov 1, 2026
16 of 17 checks passed
@Pigbibi
Pigbibi deleted the fix/console-annotations-metadata branch November 1, 2026 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

owner-approved Owner approval for high-risk PRs. AI agents must never apply this label.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant