Repository navigation
fix: resolve strategy aliases from the generated display source - #1002
Merged
Merged
Conversation
runtime_settings and the console Worker each kept a two-entry alias literal while the display config defines three, so bitcoin_etf_smart_dca resolved to itself and skipped domain, allowed-mode and frozen checks. Read the generated alias map in both places and cover the bypass with a regression test.
Pigbibi
added
the
owner-approved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AI assistance
Qoder agent, owner-authorized session.
What changed
validate_runtime_target_strategy_policykept a two-entry alias map whiledisplay-names.config.jsondefines three aliases.bitcoin_etf_smart_dcatherefore resolved to itself and bypassed the domain, allowed-execution-mode and frozen-profile checks.display_names.json/display_names_data.js), so aliases have one source.No generated projections were hand-edited;
build_display_names.py --checkstays clean.How verified
python3 python/scripts/build_display_names.py --check— match.python3 python/scripts/build_config.py --check— pass.python3 python/scripts/runtime_settings.py validate— pass.python3 -m unittest discover -s python/tests— 994 passed, 11 failures are pre-existing macOSmapfile/bash-3.2 shell-script failures unrelated to this change.python3 -m unittest -v python.tests.test_frozen_selection python.tests.test_runtime_settings python.tests.test_runtime_stop— 203 passed.node tests/frozen_strategy_selection_validation.mjs,node tests/strategy_switch_worker_validation.mjs,node tests/console_runtime_state_validation.mjs— pass.python3 scripts/check_style.py— 0 blocking, 1 pre-existing README advisory.