Skip to content

fix(drift): move Drift Check to QPK v2 task-service reusable workflow #265

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Pigbibi merged 1 commit into from
Oct 14, 2026
Merged

fix(drift): move Drift Check to QPK v2 task-service reusable workflow #265

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions .github/workflows/drift-check.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ jobs:
uses: actions/checkout@v6
with:
repository: QuantStrategyLab/QuantPlatformKit
ref: 086166458d4e3f61bb8937054cf7e69ff6ef914a
ref: eae362bd3e3fad5be59a7615eeba10be839a9934
path: external/QuantPlatformKit

- name: Set up Python
Expand Down Expand Up @@ -207,17 +207,18 @@ jobs:
contents: read
issues: write
id-token: write
uses: QuantStrategyLab/QuantPlatformKit/.github/workflows/reusable-drift-check.yml@086166458d4e3f61bb8937054cf7e69ff6ef914a
uses: QuantStrategyLab/QuantPlatformKit/.github/workflows/reusable-drift-check.yml@eae362bd3e3fad5be59a7615eeba10be839a9934
with:
strategy_domain: crypto
caller_event_name: ${{ github.event_name }}
caller_pr_head_repository: ${{ github.event.pull_request.head.repo.full_name || '' }}
snapshot_repository: QuantStrategyLab/CryptoLivePoolPipelines
snapshot_checkout_path: external/CryptoLivePoolPipelines
snapshot_repository_ref: ${{ needs.preflight_backtests.outputs.snapshot_repository_ref }}
ai_gateway_service_url: ${{ vars.AI_GATEWAY_SERVICE_URL }}
quant_platform_kit_ref: 086166458d4e3f61bb8937054cf7e69ff6ef914a
ai_service_url: ${{ vars.AI_SERVICE_URL }}
ai_service_audience: ${{ vars.AI_SERVICE_AUDIENCE }}
ai_service_reviewers_json: ${{ vars.AI_SERVICE_REVIEWERS_JSON }}
quant_platform_kit_ref: eae362bd3e3fad5be59a7615eeba10be839a9934
lifecycle_preflight_artifact: lifecycle-preflight-${{ github.run_id }}-${{ github.run_attempt }}
secrets:
codex_audit_service_url: ${{ secrets.CODEX_AUDIT_SERVICE_URL }}
snapshot_repository_token: ${{ secrets.SNAPSHOT_REPOSITORY_TOKEN || secrets.QSL_REPO_SYNC_TOKEN || github.token }}
16 changes: 12 additions & 4 deletions tests/test_drift_workflow_config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,10 +25,10 @@ def test_drift_workflow_wires_real_pipeline_inputs_and_preflight_bundle() -> Non
assert "repository: QuantStrategyLab/QuantPlatformKit" in workflow
assert (
"repository: QuantStrategyLab/QuantPlatformKit\n"
" ref: 086166458d4e3f61bb8937054cf7e69ff6ef914a\n"
" ref: eae362bd3e3fad5be59a7615eeba10be839a9934\n"
" path: external/QuantPlatformKit"
) in workflow
assert "quant_platform_kit_ref: 086166458d4e3f61bb8937054cf7e69ff6ef914a" in workflow
assert "quant_platform_kit_ref: eae362bd3e3fad5be59a7615eeba10be839a9934" in workflow
assert "python -m pip install --no-deps -e external/QuantPlatformKit" in workflow
assert "scripts/run_walk_forward_backtest.py" in workflow
assert '"--list-profiles"' in workflow
Expand All @@ -38,10 +38,18 @@ def test_drift_workflow_wires_real_pipeline_inputs_and_preflight_bundle() -> Non
assert "Upload lifecycle preflight artifact" in workflow
assert "lifecycle-preflight-${{ github.run_id }}-${{ github.run_attempt }}" in workflow
assert workflow.count("github.ref == format('refs/heads/{0}', github.event.repository.default_branch)") == 2
assert "uses: QuantStrategyLab/QuantPlatformKit/.github/workflows/reusable-drift-check.yml@086166458d4e3f61bb8937054cf7e69ff6ef914a" in workflow
assert "uses: QuantStrategyLab/QuantPlatformKit/.github/workflows/reusable-drift-check.yml@eae362bd3e3fad5be59a7615eeba10be839a9934" in workflow
assert "strategy_domain: crypto" in workflow
assert "snapshot_repository: QuantStrategyLab/CryptoLivePoolPipelines" in workflow
assert "snapshot_checkout_path: external/CryptoLivePoolPipelines" in workflow
assert "lifecycle_preflight_artifact: lifecycle-preflight-${{ github.run_id }}-${{ github.run_attempt }}" in workflow
assert "codex_audit_service_url: ${{ secrets.CODEX_AUDIT_SERVICE_URL }}" in workflow
# Retired v1 Codex/GPT/Claude reviewer wiring must not return.
assert "codex_audit_service_url" not in workflow
assert "ai_gateway_service_url" not in workflow
# V2 project-scoped task service; provider (e.g. dot) is chosen by the
# service-side project policy, not by this caller.
assert "ai_service_url: ${{ vars.AI_SERVICE_URL }}" in workflow
assert "ai_service_audience: ${{ vars.AI_SERVICE_AUDIENCE }}" in workflow
assert "ai_service_reviewers_json: ${{ vars.AI_SERVICE_REVIEWERS_JSON }}" in workflow
assert "id-token: write" in workflow
assert "secrets.SNAPSHOT_REPOSITORY_TOKEN || secrets.QSL_REPO_SYNC_TOKEN || github.token" in workflow
Loading