Repository navigation
fix(drift): move Drift Check to QPK v2 task-service reusable workflow - #265
Merged
Merged
Conversation
The pinned QPK reusable workflow (086166) still invoked the retired AIAuditBridge v1 dual-review pipeline, which only knows codex/gpt/claude reviewers. Those reviewers were removed in the v2 migration, so every critical drift review ended as reviewers_unavailable and failed the run. Pin the reusable workflow, its QPK checkout and the preflight QPK checkout to QPK main (eae362b), whose drift_review step talks to the project-scoped v2 task service. The reviewer provider (dot/grok) is selected by the service-side project policy; this caller only passes AI_SERVICE_URL, AI_SERVICE_AUDIENCE and AI_SERVICE_REVIEWERS_JSON. Review stays advisory and fail-closed. Drop the retired CODEX_AUDIT_SERVICE_URL wiring.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Drift Check has failed daily since 2026-09-27. The pinned QPK reusable workflow
086166runs the retired AIAuditBridge v1 dual-review pipeline (run_drift_dual_review.py, pinned AIAuditBridge9fe2359), which only supports codex/gpt/claude reviewers. Those were removed in the v2 migration (AIAuditBridge611c129), so reviews end inreviewers_unavailableand the step exits 3.Change
reusable-drift-check.yml,quant_platform_kit_refand the preflight QPK checkout to QPK maineae362b(v2drift_reviewover the project-scoped task service; same model UsEquityStrategies already uses).AI_SERVICE_URL,AI_SERVICE_AUDIENCE,AI_SERVICE_REVIEWERS_JSONvariables. Provider choice (dot, optionally grok) lives in the service-side project policy (Pigbibi/AIGatewaydeploy/vps/quant.json).CODEX_AUDIT_SERVICE_URLwiring; update workflow config test.Safety
vars.AI_SERVICE_RELEASE_READY; until that is set, the drift job is skipped exactly like UsEquityStrategies today.