Repository navigation
Conversation
fjhickernell
requested review from
JiangruiKang and
fjhickernell
and
a balanced review from Copilot
October 20, 2026 18:30
There was a problem hiding this comment.
🟡 Changes recommended
The analysis notebook must be publicly accessible and linked so readers can reproduce the numerical results.
1 open issue
What changed in this PR
Adds a QMCPy website article introducing mixture sampling and comparing it with probability-weighted component integration.
Changes:
- Explains the
MixtureAPI and equal-evaluation-budget experiments. - Presents numerical comparisons and practical guidance.
- Adds article-specific styling for wide equations.
| File | Description |
|---|---|
| blogs/mixed-distributions-in-qmcpy/index.qmd | Introduces mixture distributions, examples, and numerical comparisons. |
| blogs/mixed-distributions-in-qmcpy/equations.css | Enables horizontal scrolling for wide display equations. |
Review effort: Balanced
|
|
||
| Gaussian transforms use QMCPy's default PCA covariance factorization. These public-API calculations put $V$ first; the older exploratory demo used another coordinate ordering and covariance factors. Their finite-budget errors can differ even though the target distributions agree. | ||
|
|
||
| The numerical source is `demos/mixed_distributions_blog_analysis.ipynb`. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
This PR adds a new blog post introducing the
MixtureTrueMeasure in QMCPy and exploring two approaches to working with mixture distributions:The article explains the motivation through a practical manufacturing example and compares both approaches at equal computational cost.
What's Included
Mixtureimplementation.