Repository navigation
Conversation
alegresor
approved these changes
Oct 22, 2026
alegresor
left a comment
Member
There was a problem hiding this comment.
Looks good! A few non-blocking suggestions below
- In the first line you link the PR and the demo notebook. Perhaps remove the PR link and add a link to the blog when published?
- Please confirm the first line plot is the total budget and not budget per component in the orange case. It is surprising hierarchical matches or even outperforms component-based on all other tests except this first one. Perhaps this is expected though?
Collaborator
Author
|
The plots use the total evaluation budget In 1D, component integration benefits from avoiding the selector discontinuity. In higher dimensions, performance also depends on the integrand and QMC transformations, which may explain why hierarchical sampling performs comparably or better in some cases. Thanks for the suggestions! |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds a reproducibility notebook supporting the Mixed Distributions in QMCPy blog.
The notebook compares hierarchical mixture sampling and probability-weighted component integration at equal computational cost, reproducing the numerical results and figures presented in the blog.
Changes
demos/mixed_distributions_blog_analysis.ipynbwith one-dimensional and correlated higher-dimensional Gaussian mixture experiments.test/booktests/tb_mixed_distributions_blog_analysis.pyto validate saved outputs and run reduced-workload experiments efficiently in CI.scripts/colab_notebooks_manifest.jsonto register the notebook.Mixtureimplementation andmixed_distributions.ipynbdemo without modifications.