Repository navigation
Instruments built on two threads at once keep their own synthesizers - #174
Merged
Merged
Conversation
Each Instrument adopts the Keys its factory made through a list that was module-wide; two factories on two threads could take each other's. The list is per thread now (one shared holder where there's no threading.local, as on MicroPython and CircuitPython, which build on one thread).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Each
Instrumentadopts the synthesizerKeysits factory made since the last instrument, through a module-wide list. Two factories running on two threads at the same time could take each other's, so one instrument would play through another's voice engine. The list is now per thread. Where there's nothreading.local, as on MicroPython and CircuitPython, which build instruments on their one thread, it stays a single shared holder.tests/test_cpython_instrument_threads.py: thread A makes a synthesizer and waits while thread B builds a whole instrument, then A finishes. It fails on main (A's instrument gets B's keyboard) and passes here.tests/test_scheduling_seam.pynow reaches the list through_support._pending().