Repository navigation
Octaver: Both octaves - lean, for the ESP32-S3 - #168
Merged
Merged
Conversation
Patch 6 keeps patch 1's balance with Direct at 1 and both octaves at 111, 1.9 dB louder. A mixer voice at exactly 1 passes through with no multiply, which is what an S3 lacks for patch 1. The docstring says to play it on an S3, and a test holds it to patch 1 turned up 1.9 dB.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On an ESP32-S3, Octaver's Both octaves patch (1) runs at about 80.5 % of a block, just over what the S3 can keep up with, so the sound can break up. The other patches are under it.
This adds patch 6, Both octaves - lean. It keeps patch 1's balance of your note and the two octaves, but sets Direct to 1 and both octaves to 0.87, so it is about 2 dB louder. Turn the level after it down 2 dB and you hear Both octaves. The cost comes down because a mixer voice at exactly 1 passes its samples straight through, with no multiply. On the S3 it measures about 79 % of a block.
Octaver's class tests, its kit and its full lifecycle matrix pass on CPython.