AOT: ReflectionExtension::getConstants thin proxy matches Zend (#34162) - #34163
Merged
Merged
Conversation
Bake extension constant maps for thin AOT; ExternalMethod previously returned NULL. Closes #34162. Co-authored-by: Cursor <cursoragent@cursor.com>
7 tasks
PurHur
added a commit
that referenced
this pull request
Aug 23, 2026
* Trust: sync 12 vm.php-path units into compile spine (#23474). Recent AOT/stdlib landings grew Phase A inventory without spine require_once lines; north-star5-verify-fast step 2 was red (7807/7817). spine-sync --no-link restores 7819/7819 coverage; no gen-0 restamp. Co-authored-by: Cursor <cursoragent@cursor.com> * Trust: refresh spine footnotes to 7821/7821 after master race. Deduped two require_once lines that overlapped #34157/#34163 merges; inventory/docs now match Phase A SSOT. No gen-0 restamp. --------- Co-authored-by: PurHur <PurHur@users.noreply.github.com> Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ReflectionExtension::getConstants()proxy — ExternalMethod returned NULL (thencount()TypeError).ExtensionConstantGroupsfallbacks (same values VM uses whenconstantFetchBuiltinmisses).reflectionextension::getconstantsinContext.php; spine requires for Call/Runtime (also adds missing AOT: ReflectionExtension::getDependencies() returns NULL — thin AOT omits proxy (ext/reflection/php_reflection.c) #34155 GetDependencies spine requires).php-src:
ext/reflection/php_reflection.c—zim_ReflectionExtension_getConstants.Closes #34162
Test plan
./script/aot-smoke.sh→ 8 passed, 0 failedtest/repro/issue_34162_reflection_extension_getconstants_aot.php→type=array count=17 DATE_ATOM=1 SUNFUNCS_RET_DOUBLE=1./script/phpunit.sh --filter Issue34162ReflectionExtensionGetConstantsAotTest→ OK (4 tests, 15 assertions)php script/check-selfhost-spine-coverage-sync.php→ OKNot covered: full compliance suite, differential sweep,
ci-fast.sh,north-star5-verify --strict.Made with Cursor