Trust: sync compile spine coverage to 7821/7821 (#23474) - #34167
Merged
Conversation
Recent AOT/stdlib landings grew Phase A inventory without spine require_once lines; north-star5-verify-fast step 2 was red (7807/7817). spine-sync --no-link restores 7819/7819 coverage; no gen-0 restamp. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
make north-star5-verify-faststep 2 was red on master: 10–12 Phase A inventory files missing fromcompiler_lib_spine_smokeafter recent AOT/stdlib landings (ReflectionClass thin proxies, MbSearch, ReflectionExtension::getDependencies)../script/spine-sync.sh --no-link: added missingrequire_oncelines, regenerated inventory, rewrote M2 footnotes → 7821/7821, deduped overlaps with AOT: ReflectionExtension::getDependencies thin proxy matches Zend (#34155) #34157/AOT: ReflectionExtension::getConstants thin proxy matches Zend (#34162) #34163.make bootstrap-gen0-refresh-sidecar).Relates to #23474 (Pillar 1 trust /
user_release_ready).Test plan
./script/aot-smoke.sh→aot-smoke: 8 passed, 0 failedphp script/check-selfhost-spine-coverage-sync.php→OK (spine covers all 7821 inventory files)php script/check-selfhost-spine-count-sync.php→OK (spine 7821/7821 …)php script/bootstrap-inventory.php --check→OK 7821/7821./script/phpunit.sh --filter testCompilerLibSpineSmokeBundleUnitCountAndKeyUnits→ OK (1 test, 530 assertions) [pre-rebase; count now 7821]make north-star5-verify-fast→north-star5-verify: OK (fast)north-star5-verify --strict, fullrelease-readiness.shMade with Cursor