Repository navigation
feat(chi-siamo): add "Su di noi" page - #180
Merged
Merged
Conversation
Implement the "Su di noi" Figma page at /chi-siamo, the route the header already links to. The page is composed of existing components only (CardIcon, Card primitives, Glass, GradientIcon, Button, Shape/ShapeLayer) and uses the shared fluid spacing tokens (page-container, page-top, gap-section, gap-block). Sections: vision, problem, our answer, student path timeline, numbers, history/structure links and 5x1000 support. Background shapes follow the desktop Figma frame and are anchored per section; there is no mobile frame yet, so mobile has no shapes.
Contributor
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Content spanned up to 1440px, leaving only the fluid gutter (~50-60px on laptop screens) between it and the page edges. Override --container-page on this page so page-container caps it at 1200px like in Figma (262px margins on the 1728px frame). Adapt the number cards to the narrower column: tighter padding, Figma's unequal column proportions from xl, and the large icon only from 1xl, so labels stay on two lines.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements the “Su di noi” page at
/chi-siamo, linked from the existing header. The page presents PoliNetwork’s vision, community, tools, events, student journey, numbers and ways to support the association.Built on #179: merge its fluid spacing tokens first. The page retains
page-container,pt-page-top,gap-section,gap-blockand the 1200px content width.The layout uses existing
CardIcon,Card,Glass,GradientIconandButtoncomponents, fonts and typography tokens. It includes a balanced hero with section navigation, full-width question cards, compact service cards, proportionate statistics, history/structure cards and a combined 5×1000 panel. The history placeholder has been replaced with the existing 2016 origin story.The student journey switches from a vertical timeline on mobile to a horizontal layout on desktop. Decorative shapes retain the existing desktop visibility rules. Existing link targets are preserved:
/storiais implemented separately in #181;/aboutstill requires its own page.Validation:
pnpm build,pnpm typecheck,pnpm exec biome ci .andgit diff --checkpass. Browser checks at 320, 390, 768, 1024 and 1440px; no horizontal overflow or clipped text after the mobile tax-code sizing adjustment.