Repository navigation
feat(search): expand people and access searches - #67
Conversation
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 47 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
lorenzocorallo
left a comment
There was a problem hiding this comment.
Technical review completed across Standards and Spec with independent review rounds. No outstanding actionable findings. Verified partial Telegram IDs/usernames, literal SQL wildcard escaping, related role/permission search, application labels, explicit filters and read-permission boundaries. Integrated #66 and main without changing the reviewed tree. Validation: vp check, 305 unit tests, 39 PostgreSQL tests on isolated databases and production/server-bundle build pass. Live Microsoft 365, production SMTP and physical CIE hardware were outside this local validation. Administrative bypass of human approval is explicitly requested by the user.
People search now finds partial Telegram usernames with or without @, partial Telegram IDs, assigned role names/keys/descriptions, and the account and membership traits exposed by the filters. Role assignment uses the same person search while preserving role and directory read permissions; explicit filters still narrow search results.
Role and permission catalogs also search related roles and permissions, and checkbox selectors include descriptions and visible disabled reasons.
Depends on #66; this PR targets its branch to keep the search changes separate.
Validation: