Skip to content

feat(search): expand people and access searches - #67

Merged
lorenzocorallo merged 8 commits into
mainfrom
feat/expanded-directory-search
Oct 22, 2026
Merged

lorenzocorallo merged 8 commits into
mainfrom
feat/expanded-directory-search

Conversation

@viganogabriele

Copy link
Copy Markdown
Contributor

People search now finds partial Telegram usernames with or without @, partial Telegram IDs, assigned role names/keys/descriptions, and the account and membership traits exposed by the filters. Role assignment uses the same person search while preserving role and directory read permissions; explicit filters still narrow search results.

Role and permission catalogs also search related roles and permissions, and checkbox selectors include descriptions and visible disabled reasons.

Depends on #66; this PR targets its branch to keep the search changes separate.

Validation:

  • General suite: 305 tests passed; 117 opt-in tests skipped.
  • PostgreSQL directory suite: all 10 tests passed on a disposable migrated database, including partial Telegram matching, literal wildcards, combined filters, and permission boundaries.
  • Formatting, lint, and TypeScript passed for all 11 changed files.
  • Production build and server bundle validation passed.
  • The full repository formatting check still reports the pre-existing package.json formatting issue. The existing lockfile changes are excluded.

@coderabbitai

coderabbitai Bot commented Oct 21, 2026 •

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 47 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

⚙️ Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 30fa3110-67a8-47cb-9644-ce8538e49d98
📥 Commits

Reviewing files that changed from the base of the PR and between 9325ff0 and e94855d.

📒 Files selected for processing: 11
  • src/auth/people-search.ts
  • src/auth/rbac-security.integration.test.mjs
  • src/auth/rbac-store.ts
  • src/auth/user-directory.integration.test.mjs
  • src/auth/user-directory.ts
  • src/components/rbac/pick-list.tsx
  • src/components/rbac/role-members.tsx
  • src/lib/search.ts
  • src/routes/access/permissions/index.tsx
  • src/routes/access/roles/index.tsx
  • src/routes/users/index.tsx
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@lorenzocorallo
lorenzocorallo changed the base branch from feat/group-permissions-by-application to main October 22, 2026 20:13

@lorenzocorallo lorenzocorallo left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Technical review completed across Standards and Spec with independent review rounds. No outstanding actionable findings. Verified partial Telegram IDs/usernames, literal SQL wildcard escaping, related role/permission search, application labels, explicit filters and read-permission boundaries. Integrated #66 and main without changing the reviewed tree. Validation: vp check, 305 unit tests, 39 PostgreSQL tests on isolated databases and production/server-bundle build pass. Live Microsoft 365, production SMTP and physical CIE hardware were outside this local validation. Administrative bypass of human approval is explicitly requested by the user.

@lorenzocorallo
lorenzocorallo merged commit 281d7f9 into main Oct 22, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants