Skip to content

fix(workflows): step 9, keep the Fabrica checkout out of generate-check - #51

Open
seantronsen wants to merge 1 commit into
seantronsen/feat/release-attestationfrom
seantronsen/fix/codegen-lint
Open

seantronsen wants to merge 1 commit into
seantronsen/feat/release-attestationfrom
seantronsen/fix/codegen-lint

Conversation

@seantronsen

@seantronsen seantronsen commented Oct 20, 2026 •

Copy link
Copy Markdown
Contributor

Description

lint-codegen-fabrica fails on every caller, before it checks anything. It checks Fabrica out to fabrica/, inside the caller's work tree, so make generate-check sees an untracked fabrica/ and exits 2 ("Working tree must be clean"). Nobody noticed, because no repo called the reusable workflow until the testbed did (OpenCHAMI/github-actions-testbed#14).

  • lint-codegen-fabrica: adds /fabrica/ to .git/info/exclude after the Fabrica checkout.

Reproduced with the CI layout (Fabrica checked out inside the caller): generate-check exits 2 without the fix and 0 with it, and still fails when generated code has drifted.

Stacked on #50.

Testbed: OpenCHAMI/github-actions-testbed#14.

Checklist

  • My code follows the style guidelines of this project
  • I have added/updated comments where needed
  • I have added tests that prove my fix is effective or my feature works
  • I have run make test (or equivalent) locally and all tests pass
  • I have updated the relevant documentation (CLI examples, man pages, README, other docs, etc.)
  • DCO Sign-off: All commits are signed off (git commit -s) with my real name and email
  • REUSE Compliance:
    • Each new/modified source file has SPDX copyright and license headers
    • Any non-commentable files include a <filename>.license sidecar
    • All referenced licenses are present in the LICENSES/ directory

Type of Change

  • Bug fix
  • New feature
  • Breaking change
  • Documentation update
  • Dependency update
  • Build system/CI

Comment thread .github/workflows/gpg-sign-artifacts.yml Dismissed
Comment thread .github/workflows/gpg-sign-artifacts.yml Dismissed
@seantronsen
seantronsen changed the base branch from main to seantronsen/feat/release-attestation October 20, 2026 16:54
@seantronsen seantronsen changed the title Seantronsen/fix/codegen lint fix(workflows): step 9, keep the Fabrica checkout out of generate-check Oct 20, 2026
@seantronsen
seantronsen added this pull request to stack #40 October 20, 2026 16:54
Signed-off-by: Sean Tronsen <sean.tronsen@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants