Repository navigation
fix(workflows): step 9, keep the Fabrica checkout out of generate-check - #51
Open
seantronsen wants to merge 1 commit into
Open
seantronsen wants to merge 1 commit into
seantronsen wants to merge 1 commit into
Conversation
seantronsen
changed the base branch from
main
to
seantronsen/feat/release-attestation
October 20, 2026 16:54
seantronsen
added this pull request to stack #40
October 20, 2026 16:54
Signed-off-by: Sean Tronsen <sean.tronsen@gmail.com>
seantronsen
force-pushed
the
seantronsen/fix/codegen-lint
branch
from
October 20, 2026 16:55
82872b5 to
861e95d
Compare
14 of 17 tasks
seantronsen
marked this pull request as ready for review
October 20, 2026 17:18
This was referenced Oct 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
lint-codegen-fabricafails on every caller, before it checks anything. It checks Fabrica out tofabrica/, inside the caller's work tree, somake generate-checksees an untrackedfabrica/and exits 2 ("Working tree must be clean"). Nobody noticed, because no repo called the reusable workflow until the testbed did (OpenCHAMI/github-actions-testbed#14).lint-codegen-fabrica: adds/fabrica/to.git/info/excludeafter the Fabrica checkout.Reproduced with the CI layout (Fabrica checked out inside the caller):
generate-checkexits 2 without the fix and 0 with it, and still fails when generated code has drifted.Stacked on #50.
Testbed: OpenCHAMI/github-actions-testbed#14.
Checklist
make test(or equivalent) locally and all tests passgit commit -s) with my real name and email<filename>.licensesidecarLICENSES/directoryType of Change