Skip to content

feat!: testing for actions PR 51 - #14

Open
seantronsen wants to merge 2 commits into
seantronsen/testing-pr-50from
seantronsen/fabrica-testing
Open

seantronsen wants to merge 2 commits into
seantronsen/testing-pr-50from
seantronsen/fabrica-testing

Conversation

@seantronsen

@seantronsen seantronsen commented Oct 20, 2026 •

Copy link
Copy Markdown
Collaborator

Description

Note

lint-makefile-common fails until v4.0 is released (see #11).

Testbed for OpenCHAMI/github-actions#51. Converts the testbed into a minimal Fabrica project, so it can test the Fabrica code generation checks: the lint-codegen-fabrica workflow (OpenCHAMI/github-actions#39) and the generate / generate-check targets in Makefile.common (OpenCHAMI/github-actions#48).

  • Fabrica v0.4.11, with one Widget resource and file storage. The generated code is in its own commit, separate from the files written by hand.
  • The testbed binary is now the Fabrica server (./cmd/server, with serve as the image's default command). It replaces cmd/testbed. Release outputs and package contents are unchanged.
  • lint.yml: adds lint-codegen-fabrica to the lint gate, pinned to the fix(workflows): step 9, keep the Fabrica checkout out of generate-check github-actions#51 head.
  • go 1.26.10: Fabrica requires at least 1.26.6, which has a standard-library vulnerability reachable from our code (GO-2026-6617).
  • The README covers regenerating the code.

Checklist

  • My code follows the style guidelines of this project
  • I have added/updated comments where needed
  • I have added tests that prove my fix is effective or my feature works
  • I have run make test (or equivalent) locally and all tests pass
  • I have updated the relevant documentation (CLI examples, man pages, README, other docs, etc.)
  • DCO Sign-off: All commits are signed off (git commit -s) with my real name and email
  • REUSE Compliance:
    • Each new/modified source file has SPDX copyright and license headers
    • Any non-commentable files include a <filename>.license sidecar
    • All referenced licenses are present in the LICENSES/ directory

Type of Change

  • Bug fix
  • New feature
  • Breaking change
  • Documentation update
  • Dependency update
  • Build system/CI

@seantronsen
seantronsen added this pull request to stack #12 October 20, 2026 15:50
@seantronsen seantronsen self-assigned this Oct 20, 2026
@seantronsen seantronsen changed the title Seantronsen/fabrica testing feat!: testing for Fabrica codegen lint and drift check Oct 20, 2026
@seantronsen seantronsen changed the title feat!: testing for Fabrica codegen lint and drift check feat!: step 9, testing for Fabrica codegen lint and drift check Oct 20, 2026
@seantronsen seantronsen changed the title feat!: step 9, testing for Fabrica codegen lint and drift check feat!: testing for Fabrica codegen lint and drift check Oct 20, 2026
Signed-off-by: Sean Tronsen <sean.tronsen@gmail.com>
Signed-off-by: Sean Tronsen <sean.tronsen@gmail.com>
@seantronsen
seantronsen force-pushed the seantronsen/fabrica-testing branch from bf51b36 to 5a999e1 Compare October 20, 2026 17:06
@seantronsen seantronsen changed the title feat!: testing for Fabrica codegen lint and drift check feat!: testing for actions PR 51 Oct 20, 2026
@seantronsen
seantronsen marked this pull request as ready for review October 20, 2026 17:07
@seantronsen seantronsen mentioned this pull request Oct 20, 2026
11 of 17 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant