Skip to content

chore(types): retire two modules from the mypy debt list #332

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
BILLKISHORE wants to merge 2 commits into
base: main
Choose a base branch
from
Open

chore(types): retire two modules from the mypy debt list #332

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
469bf38
chore(types): drop pixel_identity_aligned from the mypy debt list
BILLKISHORE Aug 2, 2026
96df2d6
fix(types): annotate the phash image as Image.Image
BILLKISHORE Aug 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion openadapt_flow/vision/hashing.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ def phash_png(png: bytes, region: Region | None = None) -> str:
Raises:
ValueError: If ``region`` is empty after clamping.
"""
img = Image.open(io.BytesIO(png))
img: Image.Image = Image.open(io.BytesIO(png))
if region is not None:
x, y, w, h = region
x0, y0 = max(0, x), max(0, y)
Expand Down
6 changes: 1 addition & 5 deletions pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -415,9 +415,7 @@ follow_imports_for_stubs = true
# - the VLM microservice (FastAPI, dynamic): services.vlm_service.*
# - offline validation harnesses (not on the runtime path):
# validation.* (dense_surface, identity_ladder,
# pixel_identity_probe, pixel_identity_aligned,
# vlm_identity_probe)
# - perceptual hashing on numpy internals: vision.hashing
# pixel_identity_probe, vlm_identity_probe)
[[tool.mypy.overrides]]
module = [
"openadapt_flow.__main__",
Expand All @@ -437,9 +435,7 @@ module = [
"openadapt_flow.validation.dense_surface",
"openadapt_flow.validation.identity_ladder",
"openadapt_flow.validation.pixel_identity_probe",
"openadapt_flow.validation.pixel_identity_aligned",
"openadapt_flow.validation.vlm_identity_probe",
"openadapt_flow.vision.hashing",
]
ignore_errors = true

Expand Down