chore(types): retire two modules from the mypy debt list - #332
Open
BILLKISHORE wants to merge 2 commits into
Open
chore(types): retire two modules from the mypy debt list#332BILLKISHORE wants to merge 2 commits into
BILLKISHORE wants to merge 2 commits into
Conversation
The module has no type errors; it was listed but never removed.
Image.open returns ImageFile but crop returns Image, so the rebind in phash_png did not type-check. Retires vision.hashing from the debt list.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
validation.pixel_identity_alignedfrom the mypy debt list. It has no type errors.phash_pngasImage.Image, which letsvision.hashingcome off the list too.Why
Image.open()is typed as returningImageFilewhile.crop()returnsImage, so rebindingimginside the region branch was the only error invision.hashing.pixel_identity_alignedneeded nothing at all, it looks like it got fixed at some point without the entry being removed.I updated the comment block above the list as well, since it names both modules by hand.
Checks
I measured the rest of the list while I was in there: 67 errors left across 18 modules, and about half of those modules have only one or two each. Happy to keep working through them if this shape looks right to you.